Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1998303002: Use std::map, std::unique_ptr in fwl_widgetmgrimp.h (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use std::map, std::unique_ptr in fwl_widgetmgrimp.h Committed: https://pdfium.googlesource.com/pdfium/+/192bb33e621f7d29a7c940eba8b8a6050e430bf3

Patch Set 1 #

Patch Set 2 : Include <map> #

Total comments: 2

Patch Set 3 : explicit ctor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -74 lines) Patch
M xfa/fwl/core/fwl_widgetmgrimp.h View 1 2 5 chunks +22 lines, -22 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.cpp View 10 chunks +32 lines, -52 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-20 18:18:02 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1998303002/diff/20001/xfa/fwl/core/fwl_widgetmgrimp.h File xfa/fwl/core/fwl_widgetmgrimp.h (right): https://codereview.chromium.org/1998303002/diff/20001/xfa/fwl/core/fwl_widgetmgrimp.h#newcode32 xfa/fwl/core/fwl_widgetmgrimp.h:32: CFWL_WidgetMgrItem(IFWL_Widget* widget) explicit
4 years, 7 months ago (2016-05-20 19:40:11 UTC) #3
Tom Sepez
https://codereview.chromium.org/1998303002/diff/20001/xfa/fwl/core/fwl_widgetmgrimp.h File xfa/fwl/core/fwl_widgetmgrimp.h (right): https://codereview.chromium.org/1998303002/diff/20001/xfa/fwl/core/fwl_widgetmgrimp.h#newcode32 xfa/fwl/core/fwl_widgetmgrimp.h:32: CFWL_WidgetMgrItem(IFWL_Widget* widget) On 2016/05/20 19:40:11, Lei Zhang wrote: > ...
4 years, 7 months ago (2016-05-20 20:28:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998303002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998303002/40001
4 years, 7 months ago (2016-05-20 20:28:20 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 20:44:02 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/192bb33e621f7d29a7c940eba8b8a6050e43...

Powered by Google App Engine
This is Rietveld 408576698