Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1998273002: Remove custom bundle ID for iOS (Closed)

Created:
4 years, 7 months ago by stephana
Modified:
4 years, 7 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove custom bundle ID for iOS BUG=skia: R=borenet GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1998273002 Committed: https://skia.googlesource.com/skia/+/de8af07e41efd335cb0f6fad131787ac363c4970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M experimental/iOSShell/iOSShell-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M gyp/iOSShell.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/ios/bin/ios_setup.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
stephana
4 years, 7 months ago (2016-05-20 17:53:48 UTC) #2
borenet
LGTM
4 years, 7 months ago (2016-05-20 17:57:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998273002/1
4 years, 7 months ago (2016-05-20 18:08:03 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 18:20:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de8af07e41efd335cb0f6fad131787ac363c4970

Powered by Google App Engine
This is Rietveld 408576698