cc/output/software_renderer.cc - Issue 1998233002: cc: Implement and use FilterOperations::MapRectReverse for mapping backdrop bounding box.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/software_renderer.cc

Issue 1998233002: cc: Implement and use FilterOperations::MapRectReverse for mapping backdrop bounding box. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: allow for negative scale (due to framebuffer flipping) in gaussian blur calculation Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/software_renderer.cc

diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc

index 13d13418b200149d5245614386e93e7c6cac619e..cd3f69a566ff56fd4892fda842ead7e295cc2e1e 100644

--- a/cc/output/software_renderer.cc

+++ b/cc/output/software_renderer.cc

@@ -704,9 +704,10 @@ gfx::Rect SoftwareRenderer::GetBackdropBoundingBoxForRenderPassQuad(

gfx::Rect backdrop_rect = gfx::ToEnclosingRect(

MathUtil::MapClippedRect(contents_device_transform, QuadVertexRect()));

- int top, right, bottom, left;

- quad->background_filters.GetOutsets(&top, &right, &bottom, &left);

- backdrop_rect.Inset(-left, -top, -right, -bottom);

+ SkMatrix matrix;

+ matrix.setScale(quad->filters_scale.x(), quad->filters_scale.y());

+ backdrop_rect =

+ quad->background_filters.MapRectReverse(backdrop_rect, matrix);

backdrop_rect.Intersect(MoveFromDrawToWindowSpace(

frame, frame->current_render_pass->output_rect));

« cc/output/gl_renderer.cc ('K') | « cc/output/gl_renderer.cc ('k') | cc/test/data/offset_background_filter_1x.png » ('j') | no next file with comments »