Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 19982008: Revert 154802 "Don't use Vector<UChar> to build strings" (Closed)

Created:
7 years, 5 months ago by haraken
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Revert 154802 "Don't use Vector<UChar> to build strings" This CL broke webkit_unit_tests in Android bots. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/12998/steps/webkit_unit_tests/logs/stdio > Don't use Vector<UChar> to build strings > > This CL removes a bunch of code sites that were using Vector<UChar> to > construct strings. That used to be a good way to construct strings, but in the > modern world, we have much better alternatives in the form of StringBuffer and > StringBuilder. (You should use StringBuffer if you know exactly how much memory > you need and you should use StringBuilder if you require a variable amount of > memory.) > > This CL removes more clients of the StringImpl pointer. There are still a few > left, which require more study. > > R=eseidel > BUG=262320 > > Review URL: https://chromiumcodereview.appspot.com/20002008 TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M trunk/Source/bindings/v8/SerializedScriptValue.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/Source/core/css/CSSPrimitiveValue.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/platform/graphics/Color.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/platform/text/LocaleICU.cpp View 6 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haraken
7 years, 5 months ago (2013-07-24 09:26:27 UTC) #1
haraken
Committed patchset #1 manually as r154825.
7 years, 5 months ago (2013-07-24 09:26:40 UTC) #2
abarth-chromium
7 years, 5 months ago (2013-07-24 18:28:42 UTC) #3
Message was sent while issue was closed.
Thanks.  I have fixed the bug and and re-landing the patch in the original CL.

Powered by Google App Engine
This is Rietveld 408576698