sync: Remove SyncSourceInfo

sync/engine/syncer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_ENGINE_SYNCER_H_
 #define SYNC_ENGINE_SYNCER_H_
 
 #include <utility>
 #include <vector>
 
@@ skipping 28 matching lines @@
   virtual ~Syncer();
 
   // Called by other threads to tell the syncer to stop what it's doing
   // and return early from SyncShare, if possible.
   bool ExitRequested();
   void RequestEarlyExit();
 
   virtual bool NormalSyncShare(ModelTypeSet request_types,
                                const sessions::NudgeTracker& nudge_tracker,
                                sessions::SyncSession* session);
-  virtual bool ConfigureSyncShare(ModelTypeSet request_types,
-                                  sessions::SyncSession* session);
+  virtual bool ConfigureSyncShare(
+      ModelTypeSet request_types,
+      sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source,

[tim (not reviewing), 2013/08/01 17:16:38]

Can you comment the different *SyncShare functions and their parameters?  It's
more critical now that the signatures are different and we're specifying each
input individually.

[rlarocque, 2013/08/01 21:01:41]

Done.

+      sessions::SyncSession* session);
   virtual bool PollSyncShare(ModelTypeSet request_types,
                              sessions::SyncSession* session);
 
  private:
   void ApplyUpdates(sessions::SyncSession* session);
   bool DownloadAndApplyUpdates(
       sessions::SyncSession* session,
       base::Callback<SyncerError(void)> download_fn);
 
   void HandleCycleBegin(sessions::SyncSession* session);
-  bool HandleCycleEnd(sessions::SyncSession* session);
+  bool HandleCycleEnd(
+      sessions::SyncSession* session,
+      sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);
 
   bool early_exit_requested_;
   base::Lock early_exit_requested_lock_;
 
   friend class SyncerTest;
   FRIEND_TEST_ALL_PREFIXES(SyncerTest, NameClashWithResolver);
   FRIEND_TEST_ALL_PREFIXES(SyncerTest, IllegalAndLegalUpdates);
   FRIEND_TEST_ALL_PREFIXES(SyncerTest, TestCommitListOrderingAndNewParent);
   FRIEND_TEST_ALL_PREFIXES(SyncerTest,
                            TestCommitListOrderingAndNewParentAndChild);
@@ skipping 12 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(SyncerTest, DeletingEntryWithLocalEdits);
   FRIEND_TEST_ALL_PREFIXES(EntryCreatedInNewFolderTest,
                            EntryCreatedInNewFolderMidSync);
 
   DISALLOW_COPY_AND_ASSIGN(Syncer);
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_ENGINE_SYNCER_H_