sync: Remove SyncSourceInfo

chrome/browser/sync/profile_sync_service_harness.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 
 #include <cstddef>
 #include <iterator>
 #include <ostream>
 #include <set>
@@ skipping 483 matching lines @@
 void ProfileSyncServiceHarness::OnStateChanged() {
   RunStateChangeMachine();
 }
 
 void ProfileSyncServiceHarness::OnSyncCycleCompleted() {
   // Integration tests still use p2p notifications.
   const SyncSessionSnapshot& snap = GetLastSessionSnapshot();
   bool is_notifiable_commit =
       (snap.model_neutral_state().num_successful_commits > 0);
   if (is_notifiable_commit && p2p_invalidation_service_) {
-    const syncer::ObjectIdInvalidationMap& invalidation_map =
-        ModelTypeInvalidationMapToObjectIdInvalidationMap(
-            snap.source().types);
+    syncer::ModelTypeSet model_types =
+        snap.model_neutral_state().commit_request_types;

[tim (not reviewing), 2013/08/01 17:16:38]

Am I correct that we only need commit_request_types for p2p / integration tests?
 Would this be interesting for about:sync?  

[rlarocque, 2013/08/01 21:01:41]

Yep, it's only for tests.  I wish I could have avoided it, but I didn't see any
better way to keep the tests running.
The information might be useful, but I'm not sure where I'd put it.  If we ever
get around to replacing the counters with a concise event log, we might be able
to use it then.

+    syncer::ObjectIdSet ids = ModelTypeSetToObjectIdSet(model_types);
+    syncer::ObjectIdInvalidationMap invalidation_map =
+        syncer::ObjectIdSetToInvalidationMap(
+            ids,
+            syncer::Invalidation::kUnknownVersion,
+            "");
     p2p_invalidation_service_->SendInvalidation(invalidation_map);
   }
 
   OnStateChanged();
 }
 
 void ProfileSyncServiceHarness::OnMigrationStateChange() {
   // Update migration state.
   if (HasPendingBackendMigration()) {
     // Merge current pending migration types into
@@ skipping 640 matching lines @@
 
 std::string ProfileSyncServiceHarness::GetServiceStatus() {
   scoped_ptr<DictionaryValue> value(
       sync_ui_util::ConstructAboutInformation(service_));
   std::string service_status;
   base::JSONWriter::WriteWithOptions(value.get(),
                                      base::JSONWriter::OPTIONS_PRETTY_PRINT,
                                      &service_status);
   return service_status;
 }