Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: media/audio/pulse/pulse_util.h

Issue 1998173002: Use "application default" audio device as default PulseAudio device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/pulse/pulse_output.cc ('k') | media/audio/pulse/pulse_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/pulse/pulse_util.h
diff --git a/media/audio/pulse/pulse_util.h b/media/audio/pulse/pulse_util.h
index a7fd875abcb5e173250a4c8347c30468807f3a54..b8e5cdcda4c606eaef98770e1507bbff99522855 100644
--- a/media/audio/pulse/pulse_util.h
+++ b/media/audio/pulse/pulse_util.h
@@ -53,8 +53,6 @@ int GetHardwareLatencyInBytes(pa_stream* stream,
// otherwise false. |mainloop| and |context| have to be from a valid Pulse
// threaded mainloop and the handle of the created stream will be returned by
// |stream|.
-// TODO(grunell): Move this function to PulseAudioInputStream class since it's
-// only used there.
bool CreateInputStream(pa_threaded_mainloop* mainloop,
pa_context* context,
pa_stream** stream,
@@ -67,10 +65,8 @@ bool CreateInputStream(pa_threaded_mainloop* mainloop,
// otherwise false. This function will create a new Pulse threaded mainloop,
// and the handles of the mainloop, context and stream will be returned by
// |mainloop|, |context| and |stream|.
-// TODO(grunell): Move this function to PulseAudioOutputStream class since it's
-// only used there.
-bool CreateOutputStream(pa_threaded_mainloop* mainloop,
- pa_context* context,
+bool CreateOutputStream(pa_threaded_mainloop** mainloop,
+ pa_context** context,
pa_stream** stream,
const AudioParameters& params,
const std::string& device_id,
« no previous file with comments | « media/audio/pulse/pulse_output.cc ('k') | media/audio/pulse/pulse_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698