Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1998153004: ChromeVox shouldn't navigate to iframe or webview elements. (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeVox shouldn't navigate to iframe or webview elements. They're focusable, but it shouldn't be possible to directly navigate to them. BUG=613694 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/22a7571e58647fce3ab7a7259ab99ff66cef1020 Cr-Commit-Position: refs/heads/master@{#395645}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Made test more robust #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -10 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 2 2 chunks +64 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dmazzoni
4 years, 7 months ago (2016-05-20 20:51:58 UTC) #3
dmazzoni
Friendly ping
4 years, 7 months ago (2016-05-23 23:14:46 UTC) #4
David Tseng
lgtm
4 years, 7 months ago (2016-05-23 23:37:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998153004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998153004/40001
4 years, 7 months ago (2016-05-24 17:48:56 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-24 18:34:50 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 18:36:46 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/22a7571e58647fce3ab7a7259ab99ff66cef1020
Cr-Commit-Position: refs/heads/master@{#395645}

Powered by Google App Engine
This is Rietveld 408576698