Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1998143002: [deoptimizer] Support materialization of closures. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Support materialization of closures. This adds support to materialize JSFunction objects from deoptimization information. By now we need to support this because TurboFan's escape analysis can produce virtual (i.e. non-escaping) closures. R=jarin@chromium.org Committed: https://crrev.com/66d76797df41461f5b4751f3a6c9a8c71ced4316 Cr-Commit-Position: refs/heads/master@{#36400}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/deoptimizer.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-20 08:11:14 UTC) #1
Jarin
lgtm. https://codereview.chromium.org/1998143002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1998143002/diff/1/src/deoptimizer.cc#newcode3718 src/deoptimizer.cc:3718: handle(isolate_->context())); Don't you want to add a comment ...
4 years, 7 months ago (2016-05-20 08:15:24 UTC) #2
Michael Starzinger
Thanks! Comments addressed. Landing. https://codereview.chromium.org/1998143002/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1998143002/diff/1/src/deoptimizer.cc#newcode3718 src/deoptimizer.cc:3718: handle(isolate_->context())); On 2016/05/20 08:15:24, Jarin ...
4 years, 7 months ago (2016-05-20 08:32:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998143002/20001
4 years, 7 months ago (2016-05-20 09:16:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 09:18:41 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 09:20:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66d76797df41461f5b4751f3a6c9a8c71ced4316
Cr-Commit-Position: refs/heads/master@{#36400}

Powered by Google App Engine
This is Rietveld 408576698