Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1998133003: Trace wrappers for HTMLTemplateElement (Closed)

Created:
4 years, 7 months ago by Marcel Hlopko
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trace wrappers for HTMLTemplateElement This cl fixes fast/dom/HTMLTemplateElement/contentWrappers.html and fast/dom/HTMLTemplateElement/custom-element-wrapper-gc.html tests for traceWrappers. LOG=no BUG=468240 Committed: https://crrev.com/c0d4b039ee211d3f25b9cff3ce83b196aaeef1ae Cr-Commit-Position: refs/heads/master@{#395332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTemplateElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTemplateElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Marcel Hlopko
Ptal.
4 years, 7 months ago (2016-05-20 14:06:04 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-20 14:59:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998133003/1
4 years, 7 months ago (2016-05-21 17:09:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233445)
4 years, 7 months ago (2016-05-21 19:34:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998133003/1
4 years, 7 months ago (2016-05-23 07:15:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233634)
4 years, 7 months ago (2016-05-23 08:28:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998133003/1
4 years, 7 months ago (2016-05-23 09:23:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233695)
4 years, 7 months ago (2016-05-23 11:43:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998133003/1
4 years, 7 months ago (2016-05-23 14:23:40 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 15:30:56 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 15:32:25 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d4b039ee211d3f25b9cff3ce83b196aaeef1ae
Cr-Commit-Position: refs/heads/master@{#395332}

Powered by Google App Engine
This is Rietveld 408576698