Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1998113003: Make LinearSrcOverBench not crash in constructor when resource path is missing (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make LinearSrcOverBench not crash in constructor when resource path is missing GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1998113003 Committed: https://skia.googlesource.com/skia/+/809f2586707071efee1164f17b6e1ffd636cce26

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M bench/SkBlend_optsBench.cpp View 3 chunks +17 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
bsalomon
All the registered benches are constructed when the program begins. So even when running with ...
4 years, 7 months ago (2016-05-20 15:31:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998113003/40001
4 years, 7 months ago (2016-05-20 15:31:20 UTC) #7
herb_g
lgtm
4 years, 7 months ago (2016-05-20 15:36:41 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 15:52:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998113003/40001
4 years, 7 months ago (2016-05-20 15:53:31 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 15:54:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://skia.googlesource.com/skia/+/809f2586707071efee1164f17b6e1ffd636cce26

Powered by Google App Engine
This is Rietveld 408576698