Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1998093002: [crankshaft] Fix typo in AddUncasted() with 9 arguments. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@dict-lookup
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix typo in AddUncasted() with 9 arguments. ... introduced in https://codereview.chromium.org/1782743003/ TBR=bmeurer@chromium.org Committed: https://crrev.com/6e529ef1bb80e6c620bf64081cf4bfb9e9a32f66 Cr-Commit-Position: refs/heads/master@{#36389}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998093002/1
4 years, 7 months ago (2016-05-20 05:47:52 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/1908) v8_linux_mipsel_compile_rel on ...
4 years, 7 months ago (2016-05-20 05:49:03 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998093002/20001
4 years, 7 months ago (2016-05-20 06:14:13 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 06:40:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998093002/20001
4 years, 7 months ago (2016-05-20 06:54:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-20 06:56:42 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 07:00:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e529ef1bb80e6c620bf64081cf4bfb9e9a32f66
Cr-Commit-Position: refs/heads/master@{#36389}

Powered by Google App Engine
This is Rietveld 408576698