Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1998013002: X87: [turbofan] Add DebugBreak machine operator and support. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add DebugBreak machine operator and support. port 78b1585f1d148b2bbbc27f870efbe4e2787bbffb (r36355) original commit message: BUG= Committed: https://crrev.com/f16cd71df77ac0a9be4792d8cf952b4e36d0e9c0 Cr-Commit-Position: refs/heads/master@{#36388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-20 02:50:21 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-20 03:16:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998013002/1
4 years, 7 months ago (2016-05-20 03:17:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 03:40:55 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 03:42:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f16cd71df77ac0a9be4792d8cf952b4e36d0e9c0
Cr-Commit-Position: refs/heads/master@{#36388}

Powered by Google App Engine
This is Rietveld 408576698