chrome/nacl/OWNERS - Issue 19980003: NaCl: enable a real seccomp-bpf sandbox.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/nacl/OWNERS

Issue 19980003: NaCl: enable a real seccomp-bpf sandbox. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 bradchen@chromium.org	1 bradchen@chromium.org

2 bradnelson@chromium.org	2 bradnelson@chromium.org

3 jvoung@chromium.org	3 jvoung@chromium.org

4 mseaborn@chromium.org	4 mseaborn@chromium.org

5 noelallen@chromium.org	5 noelallen@chromium.org

6 sehr@chromium.org	6 sehr@chromium.org

	7

	8 per-file nacl_sandbox_linux.*=jln@chromium.org

	9 per-file nacl_sandbox_linux.*=cevans@chromium.org
	Mark Seaborn 2013/07/23 17:13:03 I'm not sure what the protocol is here -- I've hea I'm not sure what the protocol is here -- I've heard it's considered rude not to accept someone's request to be added to OWNERS. :-) I haven't reviewed any changes by cevans or had changes reviewed by him. I assume both of you will get a code review from a NaCl person if you're changing what the sandbox accepts. jln (very slow on Chromium) 2013/07/23 18:56:26 I wanted to have two OWNERS here, but how about I Show quoted text On 2013/07/23 17:13:03, Mark Seaborn wrote: > I'm not sure what the protocol is here -- I've heard it's considered rude not to > accept someone's request to be added to OWNERS. :-) I haven't reviewed any > changes by cevans or had changes reviewed by him. I assume both of you will get > a code review from a NaCl person if you're changing what the sandbox accepts. I wanted to have two OWNERS here, but how about I add you instead ? (Even though you're already in the general owners it would make it clearer who to ask about this file). I added you instead, let me know if that works.
OLD	NEW

« no previous file with comments | « no previous file | chrome/nacl/nacl_sandbox_linux.cc » ('j') | chrome/nacl/nacl_sandbox_linux.cc » ('J')