Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1997943002:
Define swarmbucket builders on master.tryserver.infra (Closed)
DescriptionDefine swarmbucket builders on master.tryserver.infra
Convert builders defined in master.tryserver.infra builders.pyl file
https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/master.tryserver.infra/builders.pyl
to swarmbucket builders. Append " OnSwarming" to builder name so
swarmbucket does not take over existing builders.
Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future
The next step is to add experimental OnSwarming builders to infra.git's
cq.cfg: https://codereview.chromium.org/1993233004/
R=estaab@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true
Patch Set 1 #Patch Set 2 : on swarming #Patch Set 3 : milo #
Total comments: 2
Patch Set 4 : (Swarming) #Messages
Total messages: 13 (8 generated)
Description was changed from ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " NoBuildbot" to builder name so swarmbucket does not take over existing builders. The next step is to add experimental NoBuidlbot builders to infra.git's cq.cfg R=estaab@chromium.org BUG= ========== to ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " NoBuildbot" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental NoBuidlbot builders to infra.git's cq.cfg R=estaab@chromium.org BUG= ==========
PTAL
Description was changed from ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " NoBuildbot" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental NoBuidlbot builders to infra.git's cq.cfg R=estaab@chromium.org BUG= ========== to ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental NoBuidlbot builders to infra.git's cq.cfg R=estaab@chromium.org BUG= ==========
Description was changed from ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental NoBuidlbot builders to infra.git's cq.cfg R=estaab@chromium.org BUG= ========== to ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental OnSwarming builders to infra.git's cq.cfg: https://codereview.chromium.org/1993233004/ R=estaab@chromium.org BUG= ==========
lgtm https://codereview.chromium.org/1997943002/diff/40001/cr-buildbucket.cfg File cr-buildbucket.cfg (right): https://codereview.chromium.org/1997943002/diff/40001/cr-buildbucket.cfg#newc... cr-buildbucket.cfg:179: name: "Depot Tools Presubmit OnSwarming" Since the rest of the name is words with spaces maybe the suffix should also be. Either "On Swarming" or "Swarming" or "(Swarming)" might be better.
Description was changed from ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental OnSwarming builders to infra.git's cq.cfg: https://codereview.chromium.org/1993233004/ R=estaab@chromium.org BUG= ========== to ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental OnSwarming builders to infra.git's cq.cfg: https://codereview.chromium.org/1993233004/ R=estaab@chromium.org BUG= NOTRYSERVER=true NOPRESUBMIT=true ==========
Description was changed from ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental OnSwarming builders to infra.git's cq.cfg: https://codereview.chromium.org/1993233004/ R=estaab@chromium.org BUG= NOTRYSERVER=true NOPRESUBMIT=true ========== to ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental OnSwarming builders to infra.git's cq.cfg: https://codereview.chromium.org/1993233004/ R=estaab@chromium.org BUG= NOTRY=true NOPRESUBMIT=true ==========
https://codereview.chromium.org/1997943002/diff/40001/cr-buildbucket.cfg File cr-buildbucket.cfg (right): https://codereview.chromium.org/1997943002/diff/40001/cr-buildbucket.cfg#newc... cr-buildbucket.cfg:179: name: "Depot Tools Presubmit OnSwarming" On 2016/05/20 00:17:35, estaab wrote: > Since the rest of the name is words with spaces maybe the suffix should also be. > Either "On Swarming" or "Swarming" or "(Swarming)" might be better. used (Swarming)
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org Link to the patchset: https://codereview.chromium.org/1997943002/#ps60001 (title: "(Swarming)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997943002/60001
Message was sent while issue was closed.
Description was changed from ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental OnSwarming builders to infra.git's cq.cfg: https://codereview.chromium.org/1993233004/ R=estaab@chromium.org BUG= NOTRY=true NOPRESUBMIT=true ========== to ========== Define swarmbucket builders on master.tryserver.infra Convert builders defined in master.tryserver.infra builders.pyl file https://chromium.googlesource.com/chromium/tools/build/+/e9f0b05/masters/mast... to swarmbucket builders. Append " OnSwarming" to builder name so swarmbucket does not take over existing builders. Category is commented out because there is no such a field in swarmbucket, but preserved in case we add it in future The next step is to add experimental OnSwarming builders to infra.git's cq.cfg: https://codereview.chromium.org/1993233004/ R=estaab@chromium.org BUG= NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 5c0ceb0cb1c670bbe130d33734597ffa59c45a0f |
