Report Metrics on No Card Polling

Report Metrics on No Card Polling

Added reporting for no cards for Google Now when one of the following causes
no cards to be polled:
* The user is signed out.
* The user has disabled Google Now in notifications.
* The user has Google Now disabled.

BUG=164227
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259142

[robliao, 2014-03-24 22:44:38]

Recommend reviewing soon to make the M35 train.

[rgustafson, 2014-03-24 23:18:26]

lgtm

https://codereview.chromium.org/199793024/diff/1/chrome/browser/resources/goo...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/199793024/diff/1/chrome/browser/resources/goo...
chrome/browser/resources/google_now/background.js:966: function
reportNoCardsMetrics(signedIn, notificationEnabled, googleNowEnabled) {
recordEventsIfNoCards possibly?

recordEvent is the terminology throughout for 'reporting metrics', and the if
makes it clear that you're not always getting no cards in this branch of the
code since that's not the case.

[robliao, 2014-03-24 23:27:03]

isherman@chromium.org: Please review changes in 
tools/metrics/histograms/histograms.xml

Thanks!

https://codereview.chromium.org/199793024/diff/1/chrome/browser/resources/goo...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/199793024/diff/1/chrome/browser/resources/goo...
chrome/browser/resources/google_now/background.js:966: function
reportNoCardsMetrics(signedIn, notificationEnabled, googleNowEnabled) {
sgtm
On 2014/03/24 23:18:26, rgustafson wrote:
> recordEventsIfNoCards possibly?
> 
> recordEvent is the terminology throughout for 'reporting metrics', and the if
> makes it clear that you're not always getting no cards in this branch of the
> code since that's not the case.

[skare_, 2014-03-24 23:29:39]

lgtm

[robliao, 2014-03-24 23:30:47]

xiyuan: Please provide owner approval for...
chrome/browser/resources/google_now/background.js
chrome/browser/resources/google_now/background_unittest.gtestjs

Thanks!

[xiyuan, 2014-03-24 23:46:47]

lgtm

[Ilya Sherman, 2014-03-25 00:26:06]

LGTM

[Ilya Sherman, 2014-03-25 00:26:14]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-03-25 00:27:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/199793024/20001

[commit-bot: I haz the power, 2014-03-25 00:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 00:33:12]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[robliao, 2014-03-25 00:33:40]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2014-03-25 00:34:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robliao@chromium.org/199793024/20001

[commit-bot: I haz the power, 2014-03-25 04:10:03]

Change committed as 259142