DevTools: Fix a bug in Array.remove

Source/devtools/front_end/utilities.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 356 matching lines @@
            leadZero(this.getDate()) + "T" +
            leadZero(this.getHours()) +
            leadZero(this.getMinutes()) +
            leadZero(this.getSeconds());
 }
 
 Object.defineProperty(Array.prototype, "remove",
 {
     /**
      * @param {!T} value
-     * @param {boolean=} onlyFirst
+     * @param {boolean=} firstOnly
      * @this {Array.<!T>}
      * @template T
      */
-    value: function(value, onlyFirst)
+    value: function(value, firstOnly)
     {
-        if (onlyFirst) {
+        if (firstOnly) {
             var index = this.indexOf(value);
             if (index !== -1)
                 this.splice(index, 1);
             return;
         }
 
-        var length = this.length;
-        for (var i = 0; i < length; ++i) {
-            if (this[i] === value)
-                this.splice(i, 1);
+        for (var pos = this.indexOf(value); pos !== -1; pos = this.indexOf(value, pos + 1)) {
+            for (var end = pos + 1; end < this.length && this[end] === value; ++end) {}
+            this.splice(pos, end - pos);

[aandrey, 2014/03/25 12:04:23]

not lgtm.
this is too complex, I think this does not worth it (do we use this code at
all?)...
why not just change "length" to "this.length" in the previous diff.

         }
     }
 });
 
 Object.defineProperty(Array.prototype, "keySet",
 {
     /**
      * @return {!Object.<string, boolean>}
      * @this {Array.<*>}
      */
@@ skipping 1124 matching lines @@
             this._outgoingCallback();
     }
 }
 
 /**
  * @param {*} value
  */
 function suppressUnused(value)
 {
 }