Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 199793022: DevTools: Fix a bug in Array.remove (Closed)

Created:
6 years, 9 months ago by alph
Modified:
6 years, 9 months ago
Reviewers:
aandrey, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Fix a bug in Array.remove Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169940

Patch Set 1 #

Total comments: 2

Patch Set 2 : Coalesce adjacent splices. #

Total comments: 1

Patch Set 3 : Turned back to a simple version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M LayoutTests/inspector/utilities.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
M LayoutTests/inspector/utilities-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/utilities.js View 1 2 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
alph
ptal
6 years, 9 months ago (2014-03-24 17:45:56 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-24 18:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/199793022/1
6 years, 9 months ago (2014-03-24 18:11:18 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:38:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 18:38:48 UTC) #5
alph
The CQ bit was checked by alph@chromium.org
6 years, 9 months ago (2014-03-24 20:24:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/199793022/1
6 years, 9 months ago (2014-03-24 20:25:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 20:26:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 20:26:14 UTC) #9
aandrey
https://codereview.chromium.org/199793022/diff/1/Source/devtools/front_end/utilities.js File Source/devtools/front_end/utilities.js (right): https://codereview.chromium.org/199793022/diff/1/Source/devtools/front_end/utilities.js#newcode393 Source/devtools/front_end/utilities.js:393: this.splice(i--, 1); FYI: the "length" is no longer valid ...
6 years, 9 months ago (2014-03-25 07:42:07 UTC) #10
alph
https://codereview.chromium.org/199793022/diff/1/Source/devtools/front_end/utilities.js File Source/devtools/front_end/utilities.js (right): https://codereview.chromium.org/199793022/diff/1/Source/devtools/front_end/utilities.js#newcode393 Source/devtools/front_end/utilities.js:393: this.splice(i--, 1); On 2014/03/25 07:42:07, aandrey wrote: > FYI: ...
6 years, 9 months ago (2014-03-25 11:43:41 UTC) #11
aandrey
https://codereview.chromium.org/199793022/diff/20001/Source/devtools/front_end/utilities.js File Source/devtools/front_end/utilities.js (right): https://codereview.chromium.org/199793022/diff/20001/Source/devtools/front_end/utilities.js#newcode392 Source/devtools/front_end/utilities.js:392: this.splice(pos, end - pos); not lgtm. this is too ...
6 years, 9 months ago (2014-03-25 12:04:23 UTC) #12
alph
ptal
6 years, 9 months ago (2014-03-25 12:10:20 UTC) #13
aandrey
lgtm
6 years, 9 months ago (2014-03-25 12:14:31 UTC) #14
alph
The CQ bit was checked by alph@chromium.org
6 years, 9 months ago (2014-03-25 12:16:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/199793022/40001
6 years, 9 months ago (2014-03-25 12:16:48 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 13:19:54 UTC) #17
Message was sent while issue was closed. 
Change committed as 169940

Powered by Google App Engine
This is Rietveld 408576698