Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 199793011: Removing "using" delclarations that import names from the STL library. (Closed)

Created:
6 years, 9 months ago by spartha
Modified:
6 years, 9 months ago
Reviewers:
dmazzoni, eae, Erik Corry
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removing "using" delclarations that import names from the STL library. This is as per the the coding guidelines for blink, which disallows importing names from the STL library through the "using" declarations. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169914

Patch Set 1 #

Patch Set 2 : Removed the empty lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M Source/core/accessibility/AXARIAGrid.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXARIAGridCell.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXARIAGridRow.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXInlineTextBox.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXList.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXListBox.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXListBoxOption.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXNodeObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXTableCell.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXTableColumn.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXTableHeaderContainer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXTableRow.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
spartha
6 years, 9 months ago (2014-03-23 07:48:04 UTC) #1
dmazzoni
Thanks for the cleanup, but please delete the extra blank lines from the top of ...
6 years, 9 months ago (2014-03-24 05:16:30 UTC) #2
spartha
On 2014/03/24 05:16:30, dmazzoni wrote: > Thanks for the cleanup, but please delete the extra ...
6 years, 9 months ago (2014-03-24 06:33:09 UTC) #3
Erik Corry
The correct way to define customized versions of std::swap is to define them as swap ...
6 years, 9 months ago (2014-03-24 08:53:55 UTC) #4
dmazzoni
lgtm
6 years, 9 months ago (2014-03-24 16:29:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/199793011/20001
6 years, 9 months ago (2014-03-24 16:29:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:32:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 17:32:06 UTC) #8
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 9 months ago (2014-03-25 05:30:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/199793011/20001
6 years, 9 months ago (2014-03-25 05:31:02 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 06:39:12 UTC) #11
Message was sent while issue was closed.
Change committed as 169914

Powered by Google App Engine
This is Rietveld 408576698