Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1997753002: Improve dumping of inferred types. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve dumping of inferred types. We now disambiguate all types by their full library URI (e.g. "dart:core.Map" instead of "Map"). In addition, we now expand function types based on local functions into their arguments and return types (e.g. "() -> dynamic" rather than "typeof(....localFunction[0].localFunction[0])". This allows more accurate comparison of AST-based and element-based summaries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/60906366076ebcd31500462b6ec4de21178198a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -61 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 16 chunks +36 lines, -15 lines 0 comments Download
M pkg/analyzer/tool/summary/dump_inferred_types.dart View 8 chunks +87 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-19 17:56:05 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-19 18:01:59 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-19 18:04:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
60906366076ebcd31500462b6ec4de21178198a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698