Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: include/codec/SkCodec.h

Issue 1997703003: Make SkPngCodec decode progressively. (Closed) Base URL: https://skia.googlesource.com/skia.git@foil
Patch Set: Respond to comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/codec/SkCodec.h
diff --git a/include/codec/SkCodec.h b/include/codec/SkCodec.h
index 50875e46c4a42cfbef1d204a0af3bfa01a74b38c..6f2a770cbd68257812de981e6377075c2a1bb37d 100644
--- a/include/codec/SkCodec.h
+++ b/include/codec/SkCodec.h
@@ -8,6 +8,8 @@
#ifndef SkCodec_DEFINED
#define SkCodec_DEFINED
+#include <functional>
+
#include "../private/SkTemplates.h"
#include "SkColor.h"
#include "SkEncodedFormat.h"
@@ -23,6 +25,10 @@ class SkData;
class SkPngChunkReader;
class SkSampler;
+namespace DM {
+class CodecSrc;
+}
+
/**
* Abstraction layer directly on top of an image codec.
*/
@@ -352,6 +358,68 @@ public:
* The remaining functions revolve around decoding scanlines.
*/
+
+ /**
+ * Prepare for an incremental decode with the specified options.
+ *
+ * This may require a rewind.
+ *
+ * @param dstInfo Info of the destination. If the dimensions do not match
+ * those of getInfo, this implies a scale.
+ * @param options Contains decoding options, including if memory is zero
+ * initialized.
+ * The callback will only be called for rows in the subset specified
+ * by fSubset.
+ * @param ctable A pointer to a color table. When dstInfo.colorType() is
+ * kIndex8, this should be non-NULL and have enough storage for 256
+ * colors. The color table will be populated after decoding the palette.
+ * @param ctableCount A pointer to the size of the color table. When
+ * dstInfo.colorType() is kIndex8, this should be non-NULL. It will
+ * be modified to the true size of the color table (<= 256) after
+ * decoding the palette.
+ * @return Enum representing success or reason for failure.
+ */
+ Result startIncrementalDecode(const SkImageInfo& dstInfo, const SkCodec::Options* = nullptr,
+ SkPMColor* ctable = nullptr, int* ctableCount = nullptr);
+
+ /**
+ * Start/continue the incremental decode.
+ *
+ * Not valid to call before calling startIncrementalDecode().
+ *
+ * After the first call, should only be called again if more data has been
+ * provided to the source SkStream.
+ *
+ * Unlike getPixels and getScanlines, this does not do any filling. This is
+ * left up to the caller, since they may be skipping lines or continuing the
+ * decode later. In the latter case, they may choose to initialize all lines
+ * first, or only initialize the remaining lines after the first call.
+ *
+ * @param callback This will be called each time a row has been decoded.
+ * The int parameter will be the number of the row (in the Options.fSubset's
+ * [fTop, fBottom), provided in startIncrementalDecode).
+ * The callback should return either a block of memory to write the row or
+ * null to skip writing this row.
+ * On consecutive calls, this should always write to the same memory.
+ * @param rowsDecoded Optional output variable returning the total number of
+ * lines initialized. This includes all lines decoded from the image, whether
+ * or not the client (via the callback) included it in the output, since
+ * the last call to startIncrementalDecode. Only meaningful if this method
+ * returns kIncompleteInput. Otherwise the implementation may not set it.
+ * Note that some implementations may have initialized this many rows, but
+ * not necessarily finished those rows (e.g. interlaced PNG). This is
+ * useful for determining what rows the client needs to initialize.
+ * @return kSuccess if all lines requested in startIncrementalDecode have
+ * been completely decoded. kIncompleteInput otherwise.
+ */
+ Result incrementalDecode(std::function<void*(int)> callback,
+ int* rowsDecoded = nullptr) {
+ if (!fStartedIncrementalDecode) {
+ return kInvalidParameters;
+ }
+ return this->onIncrementalDecode(callback, rowsDecoded);
+ }
+
/**
* Prepare for a scanline decode with the specified options.
*
@@ -468,17 +536,6 @@ public:
* Interlaced gifs are an example.
*/
kOutOfOrder_SkScanlineOrder,
-
- /*
- * Indicates that the entire image must be decoded in order to output
- * any amount of scanlines. In this case, it is a REALLY BAD IDEA to
- * request scanlines 1-by-1 or in small chunks. The client should
- * determine which scanlines are needed and ask for all of them in
- * a single call to getScanlines().
- *
- * Interlaced pngs are an example.
- */
- kNone_SkScanlineOrder,
};
/**
@@ -658,6 +715,7 @@ private:
SkImageInfo fDstInfo;
SkCodec::Options fOptions;
int fCurrScanline;
+ bool fStartedIncrementalDecode;
/**
* Return whether these dimensions are supported as a scale.
@@ -678,6 +736,16 @@ private:
return kUnimplemented;
}
+ virtual Result onStartIncrementalDecode(const SkImageInfo& /*dstInfo*/,
+ const SkCodec::Options&, SkPMColor*, int*) {
+ return kUnimplemented;
+ }
+
+ virtual Result onIncrementalDecode(std::function<void*(int)>, int*) {
+ return kUnimplemented;
+ }
+
+
virtual bool onSkipScanlines(int /*countLines*/) { return false; }
virtual int onGetScanlines(void* /*dst*/, int /*countLines*/, size_t /*rowBytes*/) { return 0; }
@@ -709,6 +777,7 @@ private:
*/
virtual SkSampler* getSampler(bool /*createIfNecessary*/) { return nullptr; }
+ friend class DM::CodecSrc; // for fillIncompleteImage
friend class SkSampledCodec;
friend class SkIcoCodec;
};
« no previous file with comments | « fuzz/fuzz.cpp ('k') | src/android/SkBitmapRegionDecoder.cpp » ('j') | src/codec/SkCodec.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698