tests/ColorSpaceTest.cpp - Issue 1997703003: Make SkPngCodec decode progressively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ColorSpaceTest.cpp

Issue 1997703003: Make SkPngCodec decode progressively. (Closed) Base URL: https://skia.googlesource.com/skia.git@foil

Patch Set: Add explanatory comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ColorSpaceTest.cpp

diff --git a/tests/ColorSpaceTest.cpp b/tests/ColorSpaceTest.cpp

index b26cec20aec254f461417efc6f64c0c14c6591fe..8cb1b9a50e7b1557b8778a00b888acb0b2f4ef3b 100644

--- a/tests/ColorSpaceTest.cpp

+++ b/tests/ColorSpaceTest.cpp

@@ -67,7 +67,10 @@ DEF_TEST(ColorSpaceParsePngICCProfile, r) {

}

SkAutoTDelete<SkCodec> codec(SkCodec::NewFromStream(stream.release()));

- REPORTER_ASSERT(r, nullptr != codec);

+ if (!codec) {

+ ERRORF(r, "Failed to create codec from a PNG. Is PNG support missing (or too old)?");

+ return;

+ }

#if (PNG_LIBPNG_VER_MAJOR > 1) || (PNG_LIBPNG_VER_MAJOR == 1 && PNG_LIBPNG_VER_MINOR >= 6)

SkColorSpace* colorSpace = codec->getColorSpace();