Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1997693002: Add application-server-key-standard-endpoint.html (Closed)

Created:
4 years, 7 months ago by Peter Beverloo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, Peter Beverloo, johnme+watch_chromium.org, harkness+watch_chromium.org, mvanouwerkerk+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add application-server-key-standard-endpoint.html This somehow got lost in my previous CL after a rebase :/ https://codereview.chromium.org/1931843002/ BUG=583753 Committed: https://crrev.com/425b46faa5fb052170c910e50463fc55d90f92b2 Cr-Commit-Position: refs/heads/master@{#394829}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html View 1 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael van Ouwerkerk
lgtm with nit https://codereview.chromium.org/1997693002/diff/1/third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html File third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html (right): https://codereview.chromium.org/1997693002/diff/1/third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html#newcode45 third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html:45: test.done(); nit: promise_test does this for ...
4 years, 7 months ago (2016-05-19 13:32:10 UTC) #2
Peter Beverloo
https://codereview.chromium.org/1997693002/diff/1/third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html File third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html (right): https://codereview.chromium.org/1997693002/diff/1/third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html#newcode45 third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html:45: test.done(); On 2016/05/19 13:32:10, Michael van Ouwerkerk wrote: > ...
4 years, 7 months ago (2016-05-19 17:46:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997693002/20001
4 years, 7 months ago (2016-05-19 17:47:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 19:21:43 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 19:23:51 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/425b46faa5fb052170c910e50463fc55d90f92b2
Cr-Commit-Position: refs/heads/master@{#394829}

Powered by Google App Engine
This is Rietveld 408576698