Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/WideRegisters.golden

Issue 1997653002: [interpreter] Bytecode register optimizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Try harder with source positions. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden ('K') | « test/cctest/interpreter/bytecode_expectations/UnaryOperators.golden ('k') | test/cctest/interpreter/bytecode_expectations/WithStatement.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/WideRegisters.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/WideRegisters.golden b/test/cctest/interpreter/bytecode_expectations/WideRegisters.golden
index 2c23cce71977b91bf555151179a51dafd9597f61..6d7f29f06d1e4968cf72bb419b9f588d30d8c4e8 100644
--- a/test/cctest/interpreter/bytecode_expectations/WideRegisters.golden
+++ b/test/cctest/interpreter/bytecode_expectations/WideRegisters.golden
@@ -171,11 +171,11 @@ snippet: "
"
frame size: 157
parameter count: 1
-bytecode array length: 8
+bytecode array length: 12
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 1494 S> */ B(Wide), B(Ldar), R16(127),
- /* 1497 E> */ B(Star), R(0),
+ /* 1494 S> */ B(Wide), B(Mov), R16(127), R16(0),
+ /* 1505 S> */ B(Wide), B(Ldar), R16(127),
/* 1516 S> */ B(Return),
]
constant pool: [
@@ -347,11 +347,11 @@ snippet: "
"
frame size: 157
parameter count: 1
-bytecode array length: 10
+bytecode array length: 12
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 1494 S> */ B(Wide), B(Ldar), R16(126),
- /* 1499 E> */ B(Wide), B(Star), R16(127),
+ /* 1494 S> */ B(Wide), B(Mov), R16(126), R16(127),
+ /* 1507 S> */ B(Wide), B(Ldar), R16(126),
/* 1520 S> */ B(Return),
]
constant pool: [
@@ -521,15 +521,13 @@ snippet: "
if (x2 > 3) { return x129; }
return x128;
"
-frame size: 158
+frame size: 157
parameter count: 1
-bytecode array length: 25
+bytecode array length: 19
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 1494 S> */ B(Ldar), R(2),
- B(Wide), B(Star), R16(157),
- B(LdaSmi), U8(3),
- /* 1501 E> */ B(Wide), B(TestGreaterThan), R16(157),
+ /* 1494 S> */ B(LdaSmi), U8(3),
+ /* 1501 E> */ B(Wide), B(TestGreaterThan), R16(2),
B(JumpIfFalse), U8(7),
/* 1508 S> */ B(Wide), B(Ldar), R16(129),
/* 1536 S> */ B(Return),
@@ -705,24 +703,20 @@ snippet: "
if (x2 > 3) { return x0; }
return x129;
"
-frame size: 158
+frame size: 157
parameter count: 1
-bytecode array length: 48
+bytecode array length: 36
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 1503 S> */ B(LdaZero),
/* 1503 E> */ B(Star), R(0),
- /* 1506 S> */ B(Wide), B(Ldar), R16(129),
- B(Wide), B(Star), R16(157),
- B(LdaSmi), U8(3),
- /* 1515 E> */ B(Wide), B(TestEqual), R16(157),
- B(JumpIfFalse), U8(8),
- /* 1534 S> */ B(Ldar), R(0),
- /* 1534 E> */ B(Wide), B(Star), R16(129),
- /* 1540 S> */ B(Ldar), R(2),
- B(Wide), B(Star), R16(157),
- B(LdaSmi), U8(3),
- /* 1547 E> */ B(Wide), B(TestGreaterThan), R16(157),
+ /* 1506 S> */ B(LdaSmi), U8(3),
+ /* 1515 E> */ B(Wide), B(TestEqual), R16(129),
+ B(JumpIfFalse), U8(10),
+ /* 1534 S> */ B(Wide), B(Mov), R16(0), R16(129),
+ B(Ldar), R(0),
+ /* 1540 S> */ B(LdaSmi), U8(3),
+ /* 1547 E> */ B(Wide), B(TestGreaterThan), R16(2),
B(JumpIfFalse), U8(5),
/* 1554 S> */ B(Ldar), R(0),
/* 1580 S> */ B(Return),
@@ -899,7 +893,7 @@ snippet: "
"
frame size: 158
parameter count: 1
-bytecode array length: 66
+bytecode array length: 58
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 1503 S> */ B(LdaZero),
@@ -908,23 +902,20 @@ bytecodes: [
/* 1515 E> */ B(Star), R(1),
/* 1523 S> */ B(LdaZero),
/* 1528 E> */ B(Wide), B(Star), R16(128),
- /* 1538 S> */ B(Wide), B(Ldar), R16(128),
- B(Wide), B(Star), R16(157),
- B(LdaSmi), U8(64),
- /* 1538 E> */ B(Wide), B(TestLessThan), R16(157),
+ /* 1538 S> */ B(LdaSmi), U8(64),
+ /* 1538 E> */ B(Wide), B(TestLessThan), R16(128),
B(JumpIfFalse), U8(35),
/* 1518 E> */ B(StackCheck),
- /* 1555 S> */ B(Ldar), R(1),
- B(Wide), B(Star), R16(157),
- /* 1561 E> */ B(Wide), B(Ldar), R16(128),
- B(Wide), B(Add), R16(157),
- /* 1558 E> */ B(Star), R(1),
+ /* 1555 S> */ B(Wide), B(Ldar), R16(128),
+ B(Wide), B(Add), R16(1),
+ /* 1558 E> */ B(Wide), B(Mov), R16(1), R16(157),
+ B(Star), R(1),
/* 1548 S> */ B(Wide), B(Ldar), R16(128),
B(ToNumber),
B(Wide), B(Star), R16(157),
B(Inc),
/* 1548 E> */ B(Wide), B(Star), R16(128),
- B(Jump), U8(-47),
+ B(Jump), U8(-39),
/* 1567 S> */ B(Wide), B(Ldar), R16(128),
/* 1580 S> */ B(Return),
]
@@ -1109,8 +1100,8 @@ bytecodes: [
B(JumpIfUndefined), U8(69),
B(JumpIfNull), U8(67),
B(ToObject),
- B(Wide), B(Star), R16(157),
B(Wide), B(ForInPrepare), R16(158),
+ B(Wide), B(Star), R16(157),
B(LdaZero),
B(Wide), B(Star), R16(161),
/* 1526 S> */ B(Wide), B(ForInDone), R16(161), R16(160),
@@ -1119,11 +1110,10 @@ bytecodes: [
B(JumpIfUndefined), U8(23),
B(Wide), B(Star), R16(128),
/* 1521 E> */ B(StackCheck),
- /* 1541 S> */ B(Ldar), R(1),
- B(Wide), B(Star), R16(162),
- /* 1547 E> */ B(Wide), B(Ldar), R16(128),
- B(Wide), B(Add), R16(162),
- /* 1544 E> */ B(Star), R(1),
+ /* 1541 S> */ B(Wide), B(Ldar), R16(128),
+ B(Wide), B(Add), R16(1),
+ /* 1544 E> */ B(Wide), B(Mov), R16(1), R16(162),
+ B(Star), R(1),
B(Wide), B(ForInStep), R16(161),
B(Wide), B(Star), R16(161),
B(Jump), U8(-49),
@@ -1301,19 +1291,15 @@ snippet: "
"
frame size: 159
parameter count: 1
-bytecode array length: 55
+bytecode array length: 53
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 1494 S> */ B(Ldar), R(64),
- B(Wide), B(Star), R16(157),
- /* 1509 E> */ B(Ldar), R(63),
- B(Wide), B(Star), R16(158),
+ /* 1494 S> */ B(Wide), B(Mov), R16(64), R16(157),
+ B(Wide), B(Mov), R16(63), R16(158),
B(Wide), B(CallRuntime), U16(Runtime::kAdd), R16(157), U16(2),
/* 1497 E> */ B(Star), R(0),
- /* 1515 S> */ B(Ldar), R(27),
- B(Wide), B(Star), R16(157),
- /* 1530 E> */ B(Wide), B(Ldar), R16(143),
- B(Wide), B(Star), R16(158),
+ /* 1515 S> */ B(Wide), B(Mov), R16(27), R16(157),
+ B(Wide), B(Mov), R16(143), R16(158),
B(Wide), B(CallRuntime), U16(Runtime::kAdd), R16(157), U16(2),
/* 1518 E> */ B(Star), R(1),
/* 1537 S> */ B(CallRuntime), U16(Runtime::kTheHole), R(0), U8(0),
« test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden ('K') | « test/cctest/interpreter/bytecode_expectations/UnaryOperators.golden ('k') | test/cctest/interpreter/bytecode_expectations/WithStatement.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698