Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden

Issue 1997653002: [interpreter] Bytecode register optimizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Try harder with source positions. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/cctest/interpreter/bytecode_expectations/ForIn.golden ('K') | « test/cctest/interpreter/bytecode_expectations/NewTarget.golden ('k') | test/cctest/interpreter/bytecode_expectations/ObjectLiteralsWide.golden » ('j') | test/cctest/interpreter/bytecode_expectations/PropertyCall.golden » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden b/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden
index 831218d573e3b092e11ff037b1453c2d2c651a91..16b547dd1f13c3e17aac1983168e6b0277d5ee39 100644
--- a/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden
@@ -13,11 +13,12 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 8
+bytecode array length: 10
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 34 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(35),
B(Star), R(0),
+ B(Ldar), R(0),
/* 46 S> */ B(Return),
]
constant pool: [
@@ -32,11 +33,12 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 8
+bytecode array length: 10
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 34 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),
B(Star), R(0),
+ B(Ldar), R(0),
/* 71 S> */ B(Return),
]
constant pool: [
@@ -74,19 +76,17 @@ handlers: [
snippet: "
var a = 1; return { val: a, val: a + 1 };
"
-frame size: 3
+frame size: 2
parameter count: 1
-bytecode array length: 26
+bytecode array length: 22
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(1),
/* 42 E> */ B(Star), R(0),
/* 45 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),
B(Star), R(1),
- /* 59 E> */ B(Ldar), R(0),
- /* 67 E> */ B(Star), R(2),
- B(LdaSmi), U8(1),
- B(Add), R(2),
+ /* 67 E> */ B(LdaSmi), U8(1),
+ B(Add), R(0),
B(StoreICSloppy), R(1), U8(1), U8(1),
B(Ldar), R(1),
/* 76 S> */ B(Return),
@@ -157,7 +157,6 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 34 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),
B(Star), R(0),
- B(Mov), R(0), R(1),
B(LdaConstant), U8(1),
B(Star), R(2),
B(CreateClosure), U8(2), U8(0),
@@ -166,6 +165,7 @@ bytecodes: [
B(Star), R(4),
B(LdaZero),
B(Star), R(5),
+ B(Mov), R(0), R(1),
B(CallRuntime), U16(Runtime::kDefineAccessorPropertyUnchecked), R(1), U8(5),
B(Ldar), R(0),
/* 68 S> */ B(Return),
@@ -189,7 +189,6 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 34 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),
B(Star), R(0),
- B(Mov), R(0), R(1),
B(LdaConstant), U8(1),
B(Star), R(2),
B(CreateClosure), U8(2), U8(0),
@@ -198,6 +197,7 @@ bytecodes: [
B(Star), R(4),
B(LdaZero),
B(Star), R(5),
+ B(Mov), R(0), R(1),
B(CallRuntime), U16(Runtime::kDefineAccessorPropertyUnchecked), R(1), U8(5),
B(Ldar), R(0),
/* 102 S> */ B(Return),
@@ -222,7 +222,6 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 34 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),
B(Star), R(0),
- B(Mov), R(0), R(1),
B(LdaConstant), U8(1),
B(Star), R(2),
B(LdaNull),
@@ -231,6 +230,7 @@ bytecodes: [
B(Star), R(4),
B(LdaZero),
B(Star), R(5),
+ B(Mov), R(0), R(1),
B(CallRuntime), U16(Runtime::kDefineAccessorPropertyUnchecked), R(1), U8(5),
B(Ldar), R(0),
/* 74 S> */ B(Return),
@@ -249,20 +249,19 @@ snippet: "
"
frame size: 6
parameter count: 1
-bytecode array length: 33
+bytecode array length: 32
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(1),
/* 42 E> */ B(Star), R(0),
/* 45 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1),
B(Star), R(1),
- B(Mov), R(1), R(2),
B(LdaSmi), U8(1),
B(Star), R(3),
- /* 57 E> */ B(Ldar), R(0),
- B(Star), R(4),
- B(LdaZero),
+ /* 57 E> */ B(LdaZero),
B(Star), R(5),
+ B(Mov), R(1), R(2),
+ B(Mov), R(0), R(4),
B(CallRuntime), U16(Runtime::kSetProperty), R(2), U8(4),
B(Ldar), R(1),
/* 62 S> */ B(Return),
@@ -284,9 +283,9 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 34 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(35),
B(Star), R(0),
- B(Mov), R(0), R(1),
B(LdaNull),
B(Star), R(2),
+ B(Mov), R(0), R(1),
B(CallRuntime), U16(Runtime::kInternalSetPrototype), R(1), U8(2),
B(Ldar), R(0),
/* 62 S> */ B(Return),
@@ -310,7 +309,6 @@ bytecodes: [
/* 42 E> */ B(Star), R(0),
/* 50 S> */ B(CreateObjectLiteral), U8(1), U8(0), U8(35),
B(Star), R(1),
- B(Mov), R(1), R(2),
/* 60 E> */ B(Ldar), R(0),
B(ToName),
B(Star), R(3),
@@ -320,6 +318,7 @@ bytecodes: [
B(Star), R(5),
B(LdaZero),
B(Star), R(6),
+ B(Mov), R(1), R(2),
B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), U8(5),
B(Ldar), R(1),
/* 69 S> */ B(Return),
@@ -337,7 +336,7 @@ snippet: "
"
frame size: 7
parameter count: 1
-bytecode array length: 43
+bytecode array length: 41
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaConstant), U8(0),
@@ -346,9 +345,7 @@ bytecodes: [
B(Star), R(1),
/* 64 E> */ B(Ldar), R(0),
B(StoreICSloppy), R(1), U8(2), U8(1),
- B(Mov), R(1), R(2),
- /* 68 E> */ B(Ldar), R(0),
- B(ToName),
+ /* 68 E> */ B(ToName),
B(Star), R(3),
B(LdaSmi), U8(1),
B(Star), R(4),
@@ -356,6 +353,7 @@ bytecodes: [
B(Star), R(5),
B(LdaZero),
B(Star), R(6),
+ B(Mov), R(1), R(2),
B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), U8(5),
B(Ldar), R(1),
/* 77 S> */ B(Return),
@@ -374,14 +372,13 @@ snippet: "
"
frame size: 7
parameter count: 1
-bytecode array length: 53
+bytecode array length: 54
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaConstant), U8(0),
/* 42 E> */ B(Star), R(0),
/* 50 S> */ B(CreateObjectLiteral), U8(1), U8(1), U8(35),
B(Star), R(1),
- B(Mov), R(1), R(2),
/* 60 E> */ B(Ldar), R(0),
B(ToName),
B(Star), R(3),
@@ -391,11 +388,12 @@ bytecodes: [
B(Star), R(5),
B(LdaZero),
B(Star), R(6),
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), U8(5),
B(Mov), R(1), R(2),
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), U8(5),
B(CreateObjectLiteral), U8(1), U8(0), U8(35),
B(Star), R(4),
- B(Star), R(3),
+ B(Mov), R(1), R(2),
+ B(Mov), R(4), R(3),
B(CallRuntime), U16(Runtime::kInternalSetPrototype), R(2), U8(2),
B(Ldar), R(1),
/* 84 S> */ B(Return),
@@ -420,7 +418,6 @@ bytecodes: [
/* 42 E> */ B(Star), R(0),
/* 50 S> */ B(CreateObjectLiteral), U8(1), U8(0), U8(35),
B(Star), R(1),
- B(Mov), R(1), R(2),
/* 60 E> */ B(Ldar), R(0),
B(ToName),
B(Star), R(3),
@@ -430,22 +427,23 @@ bytecodes: [
B(Star), R(5),
B(LdaZero),
B(Star), R(6),
- B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), U8(5),
B(Mov), R(1), R(2),
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), U8(5),
B(LdaConstant), U8(3),
B(Star), R(3),
B(CreateClosure), U8(4), U8(0),
B(Star), R(4),
B(LdaZero),
B(Star), R(5),
- B(CallRuntime), U16(Runtime::kDefineGetterPropertyUnchecked), R(2), U8(4),
B(Mov), R(1), R(2),
+ B(CallRuntime), U16(Runtime::kDefineGetterPropertyUnchecked), R(2), U8(4),
B(LdaConstant), U8(3),
B(Star), R(3),
B(CreateClosure), U8(5), U8(0),
B(Star), R(4),
B(LdaZero),
B(Star), R(5),
+ B(Mov), R(1), R(2),
B(CallRuntime), U16(Runtime::kDefineSetterPropertyUnchecked), R(2), U8(4),
B(Ldar), R(1),
/* 99 S> */ B(Return),
« test/cctest/interpreter/bytecode_expectations/ForIn.golden ('K') | « test/cctest/interpreter/bytecode_expectations/NewTarget.golden ('k') | test/cctest/interpreter/bytecode_expectations/ObjectLiteralsWide.golden » ('j') | test/cctest/interpreter/bytecode_expectations/PropertyCall.golden » ('J')

Powered by Google App Engine
This is Rietveld 408576698