Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/Generators.golden

Issue 1997653002: [interpreter] Bytecode register optimizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Try harder with source positions. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/cctest/interpreter/bytecode_expectations/ForIn.golden ('K') | « test/cctest/interpreter/bytecode_expectations/ForOf.golden ('k') | test/cctest/interpreter/bytecode_expectations/IfConditions.golden » ('j') | test/cctest/interpreter/bytecode_expectations/PropertyCall.golden » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/Generators.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Generators.golden b/test/cctest/interpreter/bytecode_expectations/Generators.golden
index 46a6b4aba2c2cdf5f5af82e930a9d8e661bfc867..a3dcd8ddf12bfac395dd6226de6dd54f55381ecc 100644
--- a/test/cctest/interpreter/bytecode_expectations/Generators.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Generators.golden
@@ -15,7 +15,7 @@ snippet: "
"
frame size: 11
parameter count: 1
-bytecode array length: 203
+bytecode array length: 202
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(20),
@@ -23,7 +23,7 @@ bytecodes: [
B(Star), R(1),
B(LdaZero),
B(TestEqualStrict), R(1),
- B(JumpIfTrue), U8(57),
+ B(JumpIfTrue), U8(56),
B(LdaSmi), U8(76),
B(Star), R(2),
B(CallRuntime), U16(Runtime::kAbort), R(2), U8(1),
@@ -33,10 +33,9 @@ bytecodes: [
B(StaContextSlot), R(context), U8(4),
/* 11 E> */ B(StackCheck),
B(Mov), R(context), R(4),
- B(Ldar), R(closure),
- B(Star), R(5),
B(LdaContextSlot), R(context), U8(4),
B(Star), R(6),
+ B(Mov), R(closure), R(5),
B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(5), U8(2),
B(StaContextSlot), R(context), U8(5),
B(Star), R(5),
@@ -59,9 +58,9 @@ bytecodes: [
B(TestEqualStrict), R(8),
B(JumpIfTrue), U8(22),
B(Jump), U8(2),
- B(Mov), R(7), R(9),
B(LdaTrue),
B(Star), R(10),
+ B(Mov), R(7), R(9),
B(CallRuntime), U16(Runtime::kCreateIterResultObject), R(9), U8(2),
B(Star), R(3),
B(LdaZero),
@@ -112,7 +111,7 @@ bytecodes: [
constant pool: [
]
handlers: [
- [38, 139, 145],
+ [38, 138, 144],
]
---
@@ -121,7 +120,7 @@ snippet: "
"
frame size: 11
parameter count: 1
-bytecode array length: 297
+bytecode array length: 296
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(26),
@@ -129,7 +128,7 @@ bytecodes: [
B(Star), R(1),
B(LdaZero),
B(TestEqualStrict), R(1),
- B(JumpIfTrue), U8(63),
+ B(JumpIfTrue), U8(62),
B(LdaSmi), U8(1),
B(TestEqualStrict), R(1),
B(JumpIfTrueConstant), U8(0),
@@ -142,10 +141,9 @@ bytecodes: [
B(StaContextSlot), R(context), U8(4),
/* 11 E> */ B(StackCheck),
B(Mov), R(context), R(4),
- B(Ldar), R(closure),
- B(Star), R(5),
B(LdaContextSlot), R(context), U8(4),
B(Star), R(6),
+ B(Mov), R(closure), R(5),
B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(5), U8(2),
B(StaContextSlot), R(context), U8(5),
B(Star), R(5),
@@ -168,9 +166,9 @@ bytecodes: [
B(TestEqualStrict), R(8),
B(JumpIfTrue), U8(22),
B(Jump), U8(2),
- B(Mov), R(7), R(9),
B(LdaTrue),
B(Star), R(10),
+ B(Mov), R(7), R(9),
B(CallRuntime), U16(Runtime::kCreateIterResultObject), R(9), U8(2),
B(Star), R(3),
B(LdaZero),
@@ -203,9 +201,9 @@ bytecodes: [
B(TestEqualStrict), R(8),
B(JumpIfTrue), U8(23),
B(Jump), U8(2),
- B(Mov), R(6), R(9),
B(LdaTrue),
B(Star), R(10),
+ B(Mov), R(6), R(9),
B(CallRuntime), U16(Runtime::kCreateIterResultObject), R(9), U8(2),
B(Star), R(3),
B(LdaSmi), U8(1),
@@ -262,7 +260,7 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [44, 224, 230],
+ [44, 223, 229],
]
---
@@ -271,7 +269,7 @@ snippet: "
"
frame size: 17
parameter count: 1
-bytecode array length: 808
+bytecode array length: 801
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(26),
@@ -279,7 +277,7 @@ bytecodes: [
B(Star), R(3),
B(LdaZero),
B(TestEqualStrict), R(3),
- B(JumpIfTrue), U8(63),
+ B(JumpIfTrue), U8(62),
B(LdaSmi), U8(1),
B(TestEqualStrict), R(3),
B(JumpIfTrueConstant), U8(3),
@@ -292,10 +290,9 @@ bytecodes: [
B(StaContextSlot), R(context), U8(4),
/* 11 E> */ B(StackCheck),
B(Mov), R(context), R(6),
- B(Ldar), R(closure),
- B(Star), R(7),
B(LdaContextSlot), R(context), U8(4),
B(Star), R(8),
+ B(Mov), R(closure), R(7),
B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(7), U8(2),
B(StaContextSlot), R(context), U8(5),
B(Star), R(7),
@@ -318,9 +315,9 @@ bytecodes: [
B(TestEqualStrict), R(10),
B(JumpIfTrue), U8(22),
B(Jump), U8(2),
- B(Mov), R(9), R(11),
B(LdaTrue),
B(Star), R(12),
+ B(Mov), R(9), R(11),
B(CallRuntime), U16(Runtime::kCreateIterResultObject), R(11), U8(2),
B(Star), R(5),
B(LdaZero),
@@ -330,8 +327,7 @@ bytecodes: [
B(Throw),
B(LdaConstant), U8(0),
B(Star), R(7),
- B(Ldar), R(closure),
- B(Star), R(8),
+ B(Mov), R(closure), R(8),
B(CallRuntime), U16(Runtime::kPushBlockContext), R(7), U8(2),
B(PushContext), R(1),
B(LdaTheHole),
@@ -385,8 +381,7 @@ bytecodes: [
/* 16 E> */ B(StackCheck),
B(LdaConstant), U8(7),
B(Star), R(11),
- B(Ldar), R(closure),
- B(Star), R(12),
+ B(Mov), R(closure), R(12),
B(CallRuntime), U16(Runtime::kPushBlockContext), R(11), U8(2),
B(PushContext), R(2),
B(LdaTheHole),
@@ -422,9 +417,9 @@ bytecodes: [
B(TestEqualStrict), R(14),
B(JumpIfTrue), U8(36),
B(Jump), U8(2),
- B(Mov), R(12), R(15),
B(LdaTrue),
B(Star), R(16),
+ B(Mov), R(12), R(15),
B(CallRuntime), U16(Runtime::kCreateIterResultObject), R(15), U8(2),
B(PopContext), R(2),
B(PopContext), R(2),
@@ -436,20 +431,19 @@ bytecodes: [
B(Star), R(8),
B(LdaZero),
B(Star), R(7),
- B(Jump), U8(78),
+ B(Jump), U8(77),
B(Ldar), R(12),
B(Throw),
B(Ldar), R(12),
B(PopContext), R(2),
B(LdaZero),
B(StaContextSlot), R(1), U8(9),
- B(Wide), B(Jump), U16(-230),
- B(Jump), U8(49),
+ B(Wide), B(Jump), U16(-229),
+ B(Jump), U8(48),
B(Star), R(12),
B(LdaConstant), U8(11),
B(Star), R(11),
- B(Ldar), R(closure),
- B(Star), R(13),
+ B(Mov), R(closure), R(13),
B(CallRuntime), U16(Runtime::kPushCatchContext), R(11), U8(3),
B(Star), R(10),
B(PushContext), R(2),
@@ -497,7 +491,7 @@ bytecodes: [
B(Star), R(10),
B(LdaSmi), U8(1),
B(TestEqualStrict), R(10),
- B(JumpIfFalse), U8(82),
+ B(JumpIfFalse), U8(81),
B(LdaContextSlot), R(1), U8(11),
B(TypeOf),
B(Star), R(10),
@@ -517,12 +511,11 @@ bytecodes: [
B(LdaContextSlot), R(1), U8(7),
B(Star), R(12),
B(CallRuntime), U16(Runtime::k_Call), R(11), U8(2),
- B(Jump), U8(30),
+ B(Jump), U8(29),
B(Star), R(12),
B(LdaConstant), U8(11),
B(Star), R(11),
- B(Ldar), R(closure),
- B(Star), R(13),
+ B(Mov), R(closure), R(13),
B(CallRuntime), U16(Runtime::kPushCatchContext), R(11), U8(3),
B(Star), R(10),
B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), R(0), U8(0),
@@ -550,21 +543,19 @@ bytecodes: [
B(JumpIfTrue), U8(10),
B(LdaSmi), U8(1),
B(TestEqualStrict), R(7),
- B(JumpIfTrue), U8(18),
- B(Jump), U8(30),
- B(Ldar), R(8),
+ B(JumpIfTrue), U8(17),
+ B(Jump), U8(28),
B(PopContext), R(1),
B(PopContext), R(1),
- B(Star), R(5),
B(LdaSmi), U8(1),
B(Star), R(4),
- B(Jump), U8(49),
- B(Ldar), R(8),
+ B(Mov), R(8), R(5),
+ B(Jump), U8(48),
B(PopContext), R(1),
B(PopContext), R(1),
- B(Star), R(5),
B(LdaSmi), U8(2),
B(Star), R(4),
+ B(Mov), R(8), R(5),
B(Jump), U8(35),
B(PopContext), R(1),
B(LdaUndefined),
@@ -638,9 +629,9 @@ constant pool: [
kInstanceTypeDontCare,
]
handlers: [
- [44, 726, 732],
- [156, 462, 468],
- [159, 413, 415],
- [570, 585, 587],
+ [44, 719, 725],
+ [154, 458, 464],
+ [157, 410, 412],
+ [566, 581, 583],
]
« test/cctest/interpreter/bytecode_expectations/ForIn.golden ('K') | « test/cctest/interpreter/bytecode_expectations/ForOf.golden ('k') | test/cctest/interpreter/bytecode_expectations/IfConditions.golden » ('j') | test/cctest/interpreter/bytecode_expectations/PropertyCall.golden » ('J')

Powered by Google App Engine
This is Rietveld 408576698