Index: test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden |
diff --git a/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden b/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden |
index c80469b303f92849a88dcb46b5a7ba88b395a793..ada3d385b8a7267230ffc27ab2f7d8518e7195d8 100644 |
--- a/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden |
+++ b/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden |
@@ -44,7 +44,7 @@ snippet: " |
" |
frame size: 2 |
parameter count: 1 |
-bytecode array length: 12 |
+bytecode array length: 14 |
bytecodes: [ |
/* 30 E> */ B(StackCheck), |
/* 42 S> */ B(LdaSmi), U8(55), |
@@ -52,6 +52,7 @@ bytecodes: [ |
/* 57 S> */ B(LdaSmi), U8(100), |
/* 57 E> */ B(Star), R(0), |
/* 57 E> */ B(Star), R(1), |
+ /* 65 S> */ B(Ldar), R(1), |
Yang
2016/05/20 08:00:55
How come we now have an additional position? It us
oth
2016/05/20 09:01:04
Yes, it matches FCG behavior. With the register op
|
/* 75 S> */ B(Return), |
] |
constant pool: [ |
@@ -67,20 +68,21 @@ snippet: " |
" |
frame size: 3 |
parameter count: 1 |
-bytecode array length: 24 |
+bytecode array length: 27 |
bytecodes: [ |
/* 30 E> */ B(StackCheck), |
/* 42 S> */ B(LdaSmi), U8(55), |
/* 42 E> */ B(Star), R(0), |
- /* 46 S> */ B(Star), R(1), |
- B(LdaSmi), U8(100), |
- /* 57 E> */ B(Star), R(0), |
+ /* 46 S> */ B(LdaSmi), U8(100), |
+ /* 57 E> */ B(Mov), R(0), R(1), |
+ B(Star), R(0), |
B(Add), R(1), |
B(Star), R(2), |
B(LdaSmi), U8(101), |
/* 69 E> */ B(Star), R(0), |
B(Add), R(2), |
/* 48 E> */ B(Star), R(0), |
+ /* 77 S> */ B(Ldar), R(0), |
Yang
2016/05/20 08:00:55
Ditto. This even seems unnecessary, since Ldar R0
oth
2016/05/20 09:01:04
The question is whether it's better to match FCG o
|
/* 87 S> */ B(Return), |
] |
constant pool: [ |
@@ -97,16 +99,14 @@ snippet: " |
" |
frame size: 3 |
parameter count: 1 |
-bytecode array length: 32 |
+bytecode array length: 30 |
bytecodes: [ |
/* 30 E> */ B(StackCheck), |
/* 42 S> */ B(LdaSmi), U8(55), |
/* 42 E> */ B(Star), R(0), |
/* 46 S> */ B(LdaSmi), U8(56), |
/* 53 E> */ B(Star), R(0), |
- B(Star), R(1), |
- /* 61 E> */ B(Ldar), R(0), |
- B(Sub), R(1), |
+ /* 61 E> */ B(Sub), R(0), |
B(Star), R(2), |
B(LdaSmi), U8(57), |
/* 68 E> */ B(Star), R(0), |
@@ -116,6 +116,7 @@ bytecodes: [ |
B(Star), R(1), |
B(Inc), |
/* 76 E> */ B(Star), R(0), |
+ /* 80 S> */ B(Ldar), R(0), |
/* 90 S> */ B(Return), |
] |
constant pool: [ |
@@ -131,14 +132,14 @@ snippet: " |
" |
frame size: 4 |
parameter count: 1 |
-bytecode array length: 32 |
+bytecode array length: 35 |
bytecodes: [ |
/* 30 E> */ B(StackCheck), |
/* 42 S> */ B(LdaSmi), U8(55), |
/* 42 E> */ B(Star), R(0), |
- /* 76 S> */ B(Star), R(2), |
- B(LdaSmi), U8(1), |
- /* 61 E> */ B(Star), R(0), |
+ /* 76 S> */ B(LdaSmi), U8(1), |
+ /* 61 E> */ B(Mov), R(0), R(2), |
+ B(Star), R(0), |
B(Add), R(2), |
B(Star), R(3), |
B(LdaSmi), U8(2), |
@@ -149,6 +150,7 @@ bytecodes: [ |
/* 81 E> */ B(Star), R(0), |
B(Add), R(2), |
/* 76 E> */ B(Star), R(1), |
+ /* 87 S> */ B(Ldar), R(1), |
/* 97 S> */ B(Return), |
] |
constant pool: [ |
@@ -164,14 +166,14 @@ snippet: " |
" |
frame size: 3 |
parameter count: 1 |
-bytecode array length: 32 |
+bytecode array length: 35 |
bytecodes: [ |
/* 30 E> */ B(StackCheck), |
/* 42 S> */ B(LdaSmi), U8(55), |
/* 42 E> */ B(Star), R(0), |
- /* 76 S> */ B(Star), R(1), |
- B(LdaSmi), U8(1), |
- /* 61 E> */ B(Star), R(0), |
+ /* 76 S> */ B(LdaSmi), U8(1), |
+ /* 61 E> */ B(Mov), R(0), R(1), |
+ B(Star), R(0), |
B(Add), R(1), |
B(Star), R(2), |
B(LdaSmi), U8(2), |
@@ -182,6 +184,7 @@ bytecodes: [ |
/* 81 E> */ B(Star), R(0), |
B(Add), R(1), |
/* 76 E> */ B(Star), R(0), |
+ /* 87 S> */ B(Ldar), R(0), |
/* 97 S> */ B(Return), |
] |
constant pool: [ |
@@ -196,23 +199,20 @@ snippet: " |
" |
frame size: 5 |
parameter count: 1 |
-bytecode array length: 70 |
+bytecode array length: 65 |
bytecodes: [ |
/* 30 E> */ B(StackCheck), |
/* 42 S> */ B(LdaSmi), U8(10), |
/* 42 E> */ B(Star), R(0), |
/* 50 S> */ B(LdaSmi), U8(20), |
/* 50 E> */ B(Star), R(1), |
- /* 54 S> */ B(Ldar), R(0), |
- B(Star), R(2), |
- B(LdaSmi), U8(1), |
- /* 68 E> */ B(Star), R(0), |
+ /* 54 S> */ B(LdaSmi), U8(1), |
+ /* 68 E> */ B(Mov), R(0), R(2), |
+ B(Star), R(0), |
B(Add), R(2), |
B(Star), R(3), |
- /* 76 E> */ B(Ldar), R(0), |
- B(Star), R(2), |
- B(LdaSmi), U8(1), |
- B(Add), R(2), |
+ /* 76 E> */ B(LdaSmi), U8(1), |
+ B(Add), R(0), |
B(Star), R(4), |
B(LdaSmi), U8(2), |
/* 88 E> */ B(Star), R(1), |