src/interpreter/bytecode-pipeline.cc - Issue 1997653002: [interpreter] Bytecode register optimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-pipeline.cc

Issue 1997653002: [interpreter] Bytecode register optimizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Try harder with source positions. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-pipeline.cc

diff --git a/src/interpreter/bytecode-pipeline.cc b/src/interpreter/bytecode-pipeline.cc

index 7bfb8151809b24055997e9a943f09c895450c0bd..92ecc043f96d9a1932b0e8abb42c2c4d0c6c772e 100644

--- a/src/interpreter/bytecode-pipeline.cc

+++ b/src/interpreter/bytecode-pipeline.cc

@@ -12,7 +12,7 @@ namespace internal {

namespace interpreter {

void BytecodeSourceInfo::Update(const BytecodeSourceInfo& entry) {

- DCHECK(entry.is_valid());

+ if (!entry.is_valid()) return;

if (!is_valid() || (entry.is_statement() && !is_statement()) ||

(entry.is_statement() && is_statement() &&

entry.source_position() > source_position())) {