Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1997633004: Removes |old| parameter from OnWindowPropertyChanged() (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes |old| parameter from OnWindowPropertyChanged() It wasn't consistently implemented and is not needed. BUG=603369 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda Cr-Commit-Position: refs/heads/master@{#394951}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M ash/wm/aura/wm_window_aura.cc View 1 chunk +1 line, -1 line 1 comment Download
M ash/wm/common/always_on_top_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/common/always_on_top_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/common/panels/panel_layout_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/common/panels/panel_layout_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/common/wm_window_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/common/workspace/workspace_layout_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/common/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
sky
https://codereview.chromium.org/1997633004/diff/1/mash/wm/bridge/wm_window_mus.cc File mash/wm/bridge/wm_window_mus.cc (right): https://codereview.chromium.org/1997633004/diff/1/mash/wm/bridge/wm_window_mus.cc#newcode590 mash/wm/bridge/wm_window_mus.cc:590: return; I accidentally removed this when addressing feedback in ...
4 years, 7 months ago (2016-05-19 23:00:11 UTC) #1
James Cook
lgtm https://codereview.chromium.org/1997633004/diff/1/ash/wm/aura/wm_window_aura.cc File ash/wm/aura/wm_window_aura.cc (right): https://codereview.chromium.org/1997633004/diff/1/ash/wm/aura/wm_window_aura.cc#newcode535 ash/wm/aura/wm_window_aura.cc:535: wm_property = WmWindowProperty::SNAP_CHILDREN_TO_PIXEL_BOUDARY; not for this CL, but ...
4 years, 7 months ago (2016-05-19 23:08:23 UTC) #2
sky
On Thu, May 19, 2016 at 4:08 PM, <jamescook@chromium.org> wrote: > lgtm > > > ...
4 years, 7 months ago (2016-05-19 23:12:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997633004/1
4 years, 7 months ago (2016-05-19 23:13:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 01:36:30 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 01:38:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/242453e1ae174aae09cb9324cf6bc38099feffda
Cr-Commit-Position: refs/heads/master@{#394951}

Powered by Google App Engine
This is Rietveld 408576698