[BattOr] Add ability to platform object to detect BattOrs.

[BattOr] Add ability to platform object to detect BattOrs.

BUG=catapult:#2309

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/fa204209615f932a5e2e6366f51dd46caea7650a

[rnephew (Reviews Here), 2016-05-19 16:33:42]

rnephew@chromium.org changed reviewers:
+ charliea@chromium.org, nednguyen@google.com

[nednguyen, 2016-05-19 16:40:33]

https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/platform/platform_backend.py (right):

https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/platform/platform_backend.py:299: android_device =
self.device if self.GetOSName() == 'android' else None
I would default this to returnbattor_wrapper.IsBattOrConnected(self.GetOSName())
& override this in android_platform_backend.IsBattOrConnected()

Note that the device object you are seeing here is
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...

When it's Android, it would be:
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...

[rnephew (Reviews Here), 2016-05-19 16:49:09]

https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/platform/platform_backend.py (right):

https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/platform/platform_backend.py:299: android_device =
self.device if self.GetOSName() == 'android' else None
On 2016/05/19 16:40:33, nednguyen wrote:
> I would default this to
returnbattor_wrapper.IsBattOrConnected(self.GetOSName())
> & override this in android_platform_backend.IsBattOrConnected()
> 
> Note that the device object you are seeing here is
>
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...
> 
> When it's Android, it would be:
>
https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/...

Done.

[nednguyen, 2016-05-19 16:53:15]

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/android_platform_backend.py (right):

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/android_platform_backend.py:739:
android_device=self.device)
is android_device the device-id string? If so, this should be
android_device=self.device.adb.GetDeviceSerial())

device here is an instance of devil.android.device_utils.DeviceUtils, I believe

[rnephew (Reviews Here), 2016-05-19 16:55:20]

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/android_platform_backend.py (right):

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/android_platform_backend.py:739:
android_device=self.device)
On 2016/05/19 16:53:15, nednguyen wrote:
> is android_device the device-id string? If so, this should be
> android_device=self.device.adb.GetDeviceSerial())
> 
> device here is an instance of devil.android.device_utils.DeviceUtils, I
believe

I have tested this locally with 2 devices. 1 With a battor 1 without. It works
as expected in both cases.

[nednguyen, 2016-05-19 17:13:43]

lgtm

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/android_platform_backend.py (right):

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/android_platform_backend.py:739:
android_device=self.device)
On 2016/05/19 16:55:19, rnephew (Reviews Here) wrote:
> On 2016/05/19 16:53:15, nednguyen wrote:
> > is android_device the device-id string? If so, this should be
> > android_device=self.device.adb.GetDeviceSerial())
> > 
> > device here is an instance of devil.android.device_utils.DeviceUtils, I
> believe
> 
> I have tested this locally with 2 devices. 1 With a battor 1 without. It works
> as expected in both cases.

Ah, looks like because DeviceUtils.__str__ returns it device serial
(https://github.com/catapult-project/catapult/blob/master/devil/devil/android/...).
Can you change this to android_device=str(self.device) with a comment that
str(device) is the device's id to make it more explicit

[charliea (OOO until 10-5), 2016-05-19 17:50:09]

lgtm w/ nit

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/cor...
File telemetry/telemetry/core/platform.py (right):

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/cor...
telemetry/telemetry/core/platform.py:403: """Returns if a BattOr is detected."""
s/Returns/Returns true

My vote is to kill the doc altogether, though: the function is self-describing,
which is better than having a comment.

[rnephew (Reviews Here), 2016-05-19 18:33:10]

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/cor...
File telemetry/telemetry/core/platform.py (right):

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/cor...
telemetry/telemetry/core/platform.py:403: """Returns if a BattOr is detected."""
On 2016/05/19 17:50:09, charliea wrote:
> s/Returns/Returns true
> 
> My vote is to kill the doc altogether, though: the function is
self-describing,
> which is better than having a comment.

Done.

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/android_platform_backend.py (right):

https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/android_platform_backend.py:739:
android_device=self.device)
On 2016/05/19 17:13:43, nednguyen wrote:
> On 2016/05/19 16:55:19, rnephew (Reviews Here) wrote:
> > On 2016/05/19 16:53:15, nednguyen wrote:
> > > is android_device the device-id string? If so, this should be
> > > android_device=self.device.adb.GetDeviceSerial())
> > > 
> > > device here is an instance of devil.android.device_utils.DeviceUtils, I
> > believe
> > 
> > I have tested this locally with 2 devices. 1 With a battor 1 without. It
works
> > as expected in both cases.
> 
> Ah, looks like because DeviceUtils.__str__ returns it device serial
>
(https://github.com/catapult-project/catapult/blob/master/devil/devil/android/...).
> Can you change this to android_device=str(self.device) with a comment that
> str(device) is the device's id to make it more explicit

Done.

[rnephew (Reviews Here), 2016-05-19 18:33:15]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2016-05-19 18:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, charliea@chromium.org
Link to the patchset: https://codereview.chromium.org/1997633003/#ps30001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 18:33:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997633003/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997633003/30001

[commit-bot: I haz the power, 2016-05-19 18:54:36]

Description was changed from

==========
[BattOr] Add ability to platform object to detect BattOrs.

BUG=catapult:#2309
==========

to

==========
[BattOr] Add ability to platform object to detect BattOrs.

BUG=catapult:#2309

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-05-19 18:54:37]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...