Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1997633003: [BattOr] Add ability to platform object to detect BattOrs. (Closed)

Created:
4 years, 7 months ago by rnephew (Reviews Here)
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[BattOr] Add ability to platform object to detect BattOrs. BUG=catapult:#2309 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/fa204209615f932a5e2e6366f51dd46caea7650a

Patch Set 1 #

Total comments: 2

Patch Set 2 : move android specific code to android backend #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M telemetry/telemetry/core/platform.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/android_platform_backend.py View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/platform_backend.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
rnephew (Reviews Here)
4 years, 7 months ago (2016-05-19 16:33:42 UTC) #2
nednguyen
https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/internal/platform/platform_backend.py File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/internal/platform/platform_backend.py#newcode299 telemetry/telemetry/internal/platform/platform_backend.py:299: android_device = self.device if self.GetOSName() == 'android' else None ...
4 years, 7 months ago (2016-05-19 16:40:33 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/internal/platform/platform_backend.py File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/1997633003/diff/1/telemetry/telemetry/internal/platform/platform_backend.py#newcode299 telemetry/telemetry/internal/platform/platform_backend.py:299: android_device = self.device if self.GetOSName() == 'android' else None ...
4 years, 7 months ago (2016-05-19 16:49:09 UTC) #4
nednguyen
https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/internal/platform/android_platform_backend.py File telemetry/telemetry/internal/platform/android_platform_backend.py (right): https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/internal/platform/android_platform_backend.py#newcode739 telemetry/telemetry/internal/platform/android_platform_backend.py:739: android_device=self.device) is android_device the device-id string? If so, this ...
4 years, 7 months ago (2016-05-19 16:53:15 UTC) #5
rnephew (Reviews Here)
https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/internal/platform/android_platform_backend.py File telemetry/telemetry/internal/platform/android_platform_backend.py (right): https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/internal/platform/android_platform_backend.py#newcode739 telemetry/telemetry/internal/platform/android_platform_backend.py:739: android_device=self.device) On 2016/05/19 16:53:15, nednguyen wrote: > is android_device ...
4 years, 7 months ago (2016-05-19 16:55:20 UTC) #6
nednguyen
lgtm https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/internal/platform/android_platform_backend.py File telemetry/telemetry/internal/platform/android_platform_backend.py (right): https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/internal/platform/android_platform_backend.py#newcode739 telemetry/telemetry/internal/platform/android_platform_backend.py:739: android_device=self.device) On 2016/05/19 16:55:19, rnephew (Reviews Here) wrote: ...
4 years, 7 months ago (2016-05-19 17:13:43 UTC) #7
charliea (OOO until 10-5)
lgtm w/ nit https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/core/platform.py File telemetry/telemetry/core/platform.py (right): https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/core/platform.py#newcode403 telemetry/telemetry/core/platform.py:403: """Returns if a BattOr is detected.""" ...
4 years, 7 months ago (2016-05-19 17:50:09 UTC) #8
rnephew (Reviews Here)
https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/core/platform.py File telemetry/telemetry/core/platform.py (right): https://codereview.chromium.org/1997633003/diff/10003/telemetry/telemetry/core/platform.py#newcode403 telemetry/telemetry/core/platform.py:403: """Returns if a BattOr is detected.""" On 2016/05/19 17:50:09, ...
4 years, 7 months ago (2016-05-19 18:33:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997633003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997633003/30001
4 years, 7 months ago (2016-05-19 18:33:19 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:54:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698