Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1997593002: Update Mac build instructions for installing command line tools. (Closed)

Created:
4 years, 7 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 7 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Mac build instructions for installing command line tools. Mac builds require OS X 10.9; since 10.9 it is possible to install the command line tools using xcode-select. The command line tools aren't always available in Xcode Preferences > Downloads. BUG=none Committed: https://crrev.com/a4e4c9973eceb766276d54970367532ef134b949 Cr-Commit-Position: refs/heads/master@{#395431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M docs/mac_build_instructions.md View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 7 months ago (2016-05-19 07:47:06 UTC) #3
dominicc (has gone to gerrit)
PTAL, quick doc update.
4 years, 7 months ago (2016-05-22 23:05:18 UTC) #5
erikchen
lgtm
4 years, 7 months ago (2016-05-23 17:09:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997593002/1
4 years, 7 months ago (2016-05-23 21:20:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 22:08:13 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 22:10:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4e4c9973eceb766276d54970367532ef134b949
Cr-Commit-Position: refs/heads/master@{#395431}

Powered by Google App Engine
This is Rietveld 408576698