Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 1997543002: [Useless] Hooking up storage manager in page model. (Closed)

Created:
4 years, 7 months ago by romax
Modified:
4 years, 6 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@shouldClean
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combined with 2015793002. [Offline Pages] Hooking up storage manager in page model. Start using ClearPagesIfNeeded() call from storage manager. Also adding a method allowing consumers of the model can call clear cache more explicitly. BUG=609357

Patch Set 1 #

Total comments: 2

Patch Set 2 : changes related to another patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M components/offline_pages/offline_page_model.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M components/offline_pages/offline_page_model.cc View 1 5 chunks +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
romax
Filip PTAL, this is how I'm thinking to call ClearPagesIfNeeded in page model. If this ...
4 years, 7 months ago (2016-05-19 02:27:43 UTC) #2
fgorski
For now we don't need to expose the API to the bridge. Don't worry about ...
4 years, 7 months ago (2016-05-19 04:16:24 UTC) #3
romax
4 years, 7 months ago (2016-05-20 00:47:50 UTC) #4
I removed ExpirePages but I'm adding PostTask/PostDelayTask in OnLoadDone and
InformSavePageDone.
I don't really have an idea how to test the changes reasonably, please let me
know if you have a thought.

https://codereview.chromium.org/1997543002/diff/1/components/offline_pages/of...
File components/offline_pages/offline_page_model.h (right):

https://codereview.chromium.org/1997543002/diff/1/components/offline_pages/of...
components/offline_pages/offline_page_model.h:219: void ExpirePages(const
OfflinePageStorageManager::ClearPageCallback&);
On 2016/05/19 04:16:23, fgorski wrote:
> Who is calling this one?

No one is calling this one as of now. I was assuming the bridge would call this,
I'll remove it.

Powered by Google App Engine
This is Rietveld 408576698