third_party/snappy/README.chromium - Issue 1997503005: ifdef Snappy's version of DISALLOW_COPY_AND_ASSIGN.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/snappy/README.chromium

Issue 1997503005: ifdef Snappy's version of DISALLOW_COPY_AND_ASSIGN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: Snappy: A fast compressor/decompressor	1 Name: Snappy: A fast compressor/decompressor

2 Short Name: snappy	2 Short Name: snappy

3 URL: http://google.github.io/snappy/	3 URL: http://google.github.io/snappy/

4 Version: 1.1.0-updates	4 Version: 1.1.0-updates

5 License: New BSD	5 License: New BSD

6 License File: src/COPYING	6 License File: src/COPYING

7 Security Critical: yes	7 Security Critical: yes

8	8

9 Description:	9 Description:

10 Compression library used by LevelDB.	10 Compression library used by LevelDB.

11	11

	12 Local Changes:

	13 * #ifdef DISALLOW_COPY_AND_ASSIGN - https://github.com/google/snappy/pull/21
	cmumford 2016/05/19 17:13:37 ifndef ? ifndef ? Peter Kasting 2016/05/19 18:09:32 I guess? I basically meant "put DISALLOW_COPY_AND Show quoted text On 2016/05/19 17:13:37, cmumford wrote: > ifndef ? I guess? I basically meant "put DISALLOW_COPY_AND_ASSIGN under preprocessor control", I used "#ifdef" generically as a euphemism for "preprocessor". I'll change it.
	14

12 Local Additions:	15 Local Additions:

13 * gyp file for building in chromium	16 * gyp file for building in chromium

14 * Suppress clang header-hygiene warning - https://code.google.com/p/snappy/iss ues/detail?id=70	17 * Suppress clang header-hygiene warning - https://code.google.com/p/snappy/iss ues/detail?id=70

15 * Suppress MSVC signed/unsigned warning - https://code.google.com/p/snappy/iss ues/detail?id=71	18 * Suppress MSVC signed/unsigned warning - https://code.google.com/p/snappy/iss ues/detail?id=71

16 * Suppress MSVC x64 size_t warnings - https://code.google.com/p/snappy/issues/ detail?id=75	19 * Suppress MSVC x64 size_t warnings - https://code.google.com/p/snappy/issues/ detail?id=75

17 * {mac,linux,win32}/snappy-stubs-public.h autogenerated public headers	20 * {mac,linux,win32}/snappy-stubs-public.h autogenerated public headers

OLD	NEW

« no previous file with comments | « no previous file | third_party/snappy/linux/snappy-stubs-public.h » ('j') | no next file with comments »