Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1997503003: Typed CSSOM: Rename LengthValue to CSSLengthValue (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh, shans
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Typed CSSOM: Rename LengthValue to CSSLengthValue This CL (along with 2 future ones) will replace https://codereview.chromium.org/1949343002/, which was very large and too hard to rebase after related file renames. Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610161 Committed: https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89 Cr-Commit-Position: refs/heads/master@{#394704}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -326 lines) Patch
A + third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/lengthValue.html View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h View 3 chunks +17 lines, -17 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 5 chunks +17 lines, -17 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/CSSLengthValue.idl View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.h View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTranslation.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CalcLength.idl View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/LengthValue.h View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/LengthValue.cpp View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/LengthValue.idl View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/Perspective.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/SimpleLength.h View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/SimpleLength.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/SimpleLength.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h View 4 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp View 7 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rjwright
Partly replaces https://codereview.chromium.org/1949343002/ because I didn't want to try to rebase it. PTAL.
4 years, 7 months ago (2016-05-19 01:41:47 UTC) #3
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-19 05:15:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997503003/20001
4 years, 7 months ago (2016-05-19 05:44:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 07:16:45 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 07:17:43 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89
Cr-Commit-Position: refs/heads/master@{#394704}

Powered by Google App Engine
This is Rietveld 408576698