Adding basic unittest manifest generation to blimp/BUILD.gn

blimp/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
 # Convenience meta-target for all of Blimp's production & test code.
 group("blimp") {
@@ skipping 61 matching lines @@
     deps += [ "//blimp/engine:unit_tests" ]
   }
 }
 
 if (is_linux) {
   test("blimp_browsertests") {
     deps = [
       "//blimp/test:engine_browsertests",
     ]
   }
+
+  _blimp_engine_env_tests_runtime_deps =
+      "$root_gen_dir/blimp-tests.runtime_deps"
+  _rebased_blimp_engine_env_tests_runtime_deps =
+      rebase_path(_blimp_engine_env_tests_runtime_deps, root_out_dir)
+
+  # This group contains Blimp Engine tests and tests of the various components
+  # the Blimp Engine depends on.  The idea is that if this group of tests pass
+  # on a given system there is a high probability the Engine will also work on
+  # that platform.
+  group("blimp_engine_env_tests_group") {
+    testonly = true
+
+    # Additional environment test targets should be added here.
+    # Executable targets and those executable targets' transitive
+    # dependencies are not considered unless that executable is listed in
+    # "data_deps". Otherwise, GN assumes that the executable (and
+    # everything it requires) is a build-time dependency only.

[Wez, 2016/06/02 00:07:20]

IIUC you're saying that write_runtime_deps will only list out the data-deps,
since they express run-time dependencies, while normal deps are assumed to be
only build-time, so get omitted?

[Jess, 2016/06/02 00:24:28]

Yes.

+    data_deps = [
+      ":blimp_unittests",
+      "//base:base_unittests",
+    ]
+
+    write_runtime_deps = _blimp_engine_env_tests_runtime_deps
+  }
+
+  _blimp_engine_env_tests_manifest = "$root_gen_dir/blimp-tests-manifest.txt"
+  _rebased_blimp_engine_env_tests_manifest =
+      rebase_path(_blimp_engine_env_tests_manifest, root_out_dir)
+  _rebased_blimp_engine_env_tests_blacklist =
+      rebase_path("//blimp/tools/tests-manifest-blacklist.txt")
+
+  action("generate_blimp_engine_env_tests_manifest") {

[Wez, 2016/06/02 00:07:20]

Is there something elsewhere that will depend on this, or is it intended to be
built explicitly

[Jess, 2016/06/02 00:24:28]

The action that creates the tarball will depend on this file.  I have a separate
dependent change queued up for it.

+    testonly = true
+    script = "//blimp/tools/generate-target-manifest.py"
+    args = [
+      "--blacklist",
+      _rebased_blimp_engine_env_tests_blacklist,
+      "--runtime-deps-file",
+      _rebased_blimp_engine_env_tests_runtime_deps,
+      "--output",
+      _rebased_blimp_engine_env_tests_manifest,
+    ]
+    inputs = [
+      _blimp_engine_env_tests_runtime_deps,
+    ]
+    outputs = [
+      _blimp_engine_env_tests_manifest,
+    ]
+
+    # By specifying a dependency (not a data_dependency) on :blimp_tests_group,

[Wez, 2016/06/02 00:07:20]

nit: Why does it need to be a public_dep?

[Jess, 2016/06/02 00:24:28]

It doesn't. Fixed.

+    # we can be sure that everything is built before the action is
+    # complete (though not necessarily before we generate the manifest
+    # itself).
+    public_deps = [
+      ":blimp_engine_env_tests_group",
+    ]
+  }
 }