blimp/tools/tests-manifest-blacklist.txt - Issue 1997493002: Adding basic unittest manifest generation to blimp/BUILD.gn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/tools/tests-manifest-blacklist.txt

Issue 1997493002: Adding basic unittest manifest generation to blimp/BUILD.gn (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merging test manifests as discussed offline. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Listing of filename patterns to be excluded from the Blimp Docker manifest.	1 # Listing of filename patterns to be excluded from the Blimp unittests Docker

	2 # manifest.

2 # Wildcards (* or ?) are allowed.	3 # Wildcards (* or ?) are allowed.

3

4 */manifest.json	4 */manifest.json

5 *.mojo	5 *.mojo

6 *mojom.js	6 *mojom.js

7 /mus_app_resources_.pak	7 /mus_app_resources_.pak

8 ./libfont_service_library.so	8 ./libfont_service_library.so

9 ./libtracing_library.so	9 ./libtracing_library.so

	10 ./libmalloc_wrapper.so
	Sriram 2016/05/26 00:06:19 Why are you blacklisting this library? The test wi Why are you blacklisting this library? The test will not start without this. Jess 2016/05/26 00:39:39 I was operating under the assumption this shared o Show quoted text On 2016/05/26 00:06:19, Sriram wrote: > Why are you blacklisting this library? The test will not start without this. I was operating under the assumption this shared object was a system file. Wouldn't we instead want this to come from the system we are running on? Or am I missing some way in which this library is different than the others listed here? Jess 2016/05/27 16:44:50 Confirmed my assumption was wrong on my own. Remov Show quoted text On 2016/05/26 00:39:39, Jess wrote: > On 2016/05/26 00:06:19, Sriram wrote: > > Why are you blacklisting this library? The test will not start without this. > > I was operating under the assumption this shared object was a system file. > Wouldn't we instead want this to come from the system we are running on? Or am I > missing some way in which this library is different than the others listed here? Confirmed my assumption was wrong on my own. Removed from blacklist.
10 ./libmus_library.so	11 ./libmus_library.so

11 ./libosmesa.so	12 ./libosmesa.so

12 ./libresource_provider_library.so

13 ./mojo_runner	13 ./mojo_runner

14 snapshot_blob.bin	14 snapshot_blob.bin

	15 */test_env.py

	16 pyproto/google/*

OLD	NEW

« no previous file with comments | « blimp/BUILD.gn ('k') | no next file » | no next file with comments »