Fix debugger

Fix debugger

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/adda29b31dc8fe2f8d1a5c1304384988503384c8

[Jacob, 2016-05-20 00:35:26]

jacobr@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-05-20 01:30:39]

lgtm with comments

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:11: import 'dart:html' as html;
Nothing in dart:core, etc depends on debugger, right?  Right now, we can break
the dom libs out - they're a separate strongly connected component.

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:276: if (object == null ||
null.toString()?  perhaps return "null"?

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:350: // Dart properties according to Dart
calling conventions.
We have some of this metadata encoded on the type (e.g., dart.setSignature). 
Perhaps more robust to get it from there?

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:381: if (customNames.contains(name) || name
== className) continue;
You're getting an SDK error on this.  :-)

[Jacob, 2016-05-20 17:02:36]

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:11: import 'dart:html' as html;
On 2016/05/20 01:30:39, vsm wrote:
> Nothing in dart:core, etc depends on debugger, right?  Right now, we can break
> the dom libs out - they're a separate strongly connected component.

Nothing depends on the _debugger library. The only reason it is in the sdk is to
access internal dart:_ libraries.
It would be reasonable to keep it in its own component only included if a user
has the Dart Devtools Extension installed.

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:276: if (object == null ||
On 2016/05/20 01:30:39, vsm wrote:
> null.toString()?  perhaps return "null"?

null.toString is defined as "null" in Dart so we don't have to special case it.
https://api.dartlang.org/dev/1.17.0-dev.1.0/dart-core/Null/toString.html

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:350: // Dart properties according to Dart
calling conventions.
On 2016/05/20 01:30:39, vsm wrote:
> We have some of this metadata encoded on the type (e.g., dart.setSignature). 
> Perhaps more robust to get it from there?

Agreed that would be much better. Adding a TODO. Perhaps that can be an intern
getting started task? :)

https://codereview.chromium.org/1997473007/diff/1/tool/input_sdk/private/debu...
tool/input_sdk/private/debugger.dart:381: if (customNames.contains(name) || name
== className) continue;
On 2016/05/20 01:30:39, vsm wrote:
> You're getting an SDK error on this.  :-)

Wow. Fixed.

[Jacob, 2016-05-20 18:11:50]

Description was changed from

==========
Fix debugger

BUG=
==========

to

==========
Fix debugger

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/adda29b31dc8fe2f8d1a5c130438...
==========

[Jacob, 2016-05-20 18:11:51]

Committed patchset #2 (id:20001) manually as
adda29b31dc8fe2f8d1a5c1304384988503384c8 (presubmit successful).