Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issue 1997473006: [Material][Mac]Move the Omnibox left icons 1px to the right (Closed)

Created:
4 years, 7 months ago by spqchan
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek, shrike
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the Omnibox left icons 1px to the right BUG=606204 Committed: https://crrev.com/29d7bbf9f9142707175b5357729209089974ef33 Cr-Commit-Position: refs/heads/master@{#394921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 4 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
spqchan
PTAL
4 years, 7 months ago (2016-05-19 22:12:42 UTC) #3
shrike
lgtm
4 years, 7 months ago (2016-05-19 22:26:42 UTC) #4
spqchan
+rsesek for OWNERS
4 years, 7 months ago (2016-05-19 22:28:52 UTC) #6
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-19 22:29:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997473006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997473006/1
4 years, 7 months ago (2016-05-19 22:36:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 00:16:27 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 00:19:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29d7bbf9f9142707175b5357729209089974ef33
Cr-Commit-Position: refs/heads/master@{#394921}

Powered by Google App Engine
This is Rietveld 408576698