mojo/public/cpp/bindings/tests/synchronous_connector_unittest.cc - Issue 1997473005: Remove requirement that mojo::Environment be instantiated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/synchronous_connector_unittest.cc

Issue 1997473005: Remove requirement that mojo::Environment be instantiated. (Closed) Base URL: https://github.com/domokit/mojo.git@work797_no_utility_tls

Patch Set: SetDefaultAsyncWaiter Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/struct_unittest.cc ('k') | mojo/public/cpp/bindings/tests/synchronous_interface_ptr_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/synchronous_connector_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/synchronous_connector_unittest.cc b/mojo/public/cpp/bindings/tests/synchronous_connector_unittest.cc

index 7d0bc638ba1afeec68cdcb9fdbc383f3143b7467..4ef1ca92c6e34365bc8eb85f5203c7c04bf6b9d8 100644

--- a/mojo/public/cpp/bindings/tests/synchronous_connector_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/synchronous_connector_unittest.cc

@@ -46,7 +46,6 @@ TEST(SynchronousConnectorTest, Basic) {

// Writing to a closed pipe should fail.

TEST(SynchronousConnectorTest, WriteToClosedPipe) {

- Environment env;

MessagePipe pipe;

internal::SynchronousConnector connector0(std::move(pipe.handle0));

@@ -59,7 +58,6 @@ TEST(SynchronousConnectorTest, WriteToClosedPipe) {

// Reading from a closed pipe should fail (while waiting on it).

TEST(SynchronousConnectorTest, ReadFromClosedPipe) {

- Environment env;

MessagePipe pipe;

internal::SynchronousConnector connector0(std::move(pipe.handle0));