Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

Issue 1997473005: Remove requirement that mojo::Environment be instantiated. (Closed) Base URL: https://github.com/domokit/mojo.git@work797_no_utility_tls
Patch Set: SetDefaultAsyncWaiter Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/sample_service_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
index 2ef710b2edfe268c9e8fa93a2352fb315fd5f2d4..31d829e3fd32a4f3f4dbf45f20e0a68da705ceca 100644
--- a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
@@ -7,7 +7,6 @@
#include <string>
#include <utility>
-#include "mojo/public/cpp/environment/environment.h"
#include "mojo/public/cpp/system/macros.h"
#include "mojo/public/interfaces/bindings/tests/sample_service.mojom.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -315,18 +314,7 @@ class SimpleMessageReceiver : public mojo::MessageReceiverWithResponder {
}
};
-class BindingsSampleTest : public testing::Test {
- public:
- BindingsSampleTest() {}
- ~BindingsSampleTest() override {}
-
- private:
- mojo::Environment env_;
-
- MOJO_DISALLOW_COPY_AND_ASSIGN(BindingsSampleTest);
-};
-
-TEST_F(BindingsSampleTest, Basic) {
+TEST(BindingsSampleTest, Basic) {
SimpleMessageReceiver receiver;
// User has a proxy to a Service somehow.
@@ -348,7 +336,7 @@ TEST_F(BindingsSampleTest, Basic) {
delete service;
}
-TEST_F(BindingsSampleTest, DefaultValues) {
+TEST(BindingsSampleTest, DefaultValues) {
DefaultsTestPtr defaults(DefaultsTest::New());
EXPECT_EQ(-12, defaults->a0);
EXPECT_EQ(kTwelve, defaults->a1);
« no previous file with comments | « mojo/public/cpp/bindings/tests/router_unittest.cc ('k') | mojo/public/cpp/bindings/tests/serialization_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698