Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: mojo/public/cpp/environment/environment.h

Issue 1997473005: Remove requirement that mojo::Environment be instantiated. (Closed) Base URL: https://github.com/domokit/mojo.git@work797_no_utility_tls
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_ 5 #ifndef MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_
6 #define MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_ 6 #define MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_
7 7
8 #include "mojo/public/cpp/system/macros.h" 8 #include "mojo/public/cpp/system/macros.h"
9 9
10 struct MojoAsyncWaiter; 10 struct MojoAsyncWaiter;
11 struct MojoLogger; 11 struct MojoLogger;
12 12
13 namespace mojo { 13 namespace mojo {
14 14
15 // Other parts of the Mojo C++ APIs use the *static* methods of this class. 15 // This class just acts as a "namespace": it only has static methods (whose
16 // 16 // implementation may be varied). Note that some implementations may require
17 // The "standalone" implementation of this class requires that this class (in 17 // their own explicit initialization/shut down functions to be called.
18 // the lib/ subdirectory) be instantiated (and remain so) while using the Mojo
19 // C++ APIs. I.e., the static methods depend on things set up by the constructor
20 // and torn down by the destructor.
21 //
22 // Other implementations may not have this requirement.
23 class Environment { 18 class Environment {
24 public: 19 public:
25 Environment();
26 // This constructor allows the standard implementations to be overridden (set
27 // a parameter to null to get the standard implementation).
28 Environment(const MojoAsyncWaiter* default_async_waiter,
vardhan 2016/05/20 18:38:06 if the default async waiter or default logger do n
viettrungluu 2016/05/20 21:09:46 Either that, or some implementations may require e
29 const MojoLogger* default_logger);
30 ~Environment();
31
32 static const MojoAsyncWaiter* GetDefaultAsyncWaiter(); 20 static const MojoAsyncWaiter* GetDefaultAsyncWaiter();
vardhan 2016/05/20 18:38:06 should we have a SetDefaultAsyncWaitier() as well?
viettrungluu 2016/05/20 21:09:46 Done.
33 21
34 static const MojoLogger* GetDefaultLogger(); 22 static const MojoLogger* GetDefaultLogger();
35 // Setting the logger to null will use the standard implementation. 23 // Setting the logger to null will use the standard implementation.
36 static void SetDefaultLogger(const MojoLogger* logger); 24 static void SetDefaultLogger(const MojoLogger* logger);
37 25
38 // These instantiate and destroy an environment-specific run loop for the 26 // These instantiate and destroy an environment-specific run loop for the
39 // current thread, allowing |GetDefaultAsyncWaiter()| to be used. (The run 27 // current thread, allowing |GetDefaultAsyncWaiter()| to be used. (The run
40 // loop itself should be accessible via thread-local storage, using methods 28 // loop itself should be accessible via thread-local storage, using methods
41 // specific to the run loop implementation.) Creating and destroying nested 29 // specific to the run loop implementation.) Creating and destroying nested
42 // run loops is not supported. 30 // run loops is not supported.
43 static void InstantiateDefaultRunLoop(); 31 static void InstantiateDefaultRunLoop();
44 static void DestroyDefaultRunLoop(); 32 static void DestroyDefaultRunLoop();
45 33
46 private: 34 private:
47 MOJO_DISALLOW_COPY_AND_ASSIGN(Environment); 35 Environment() = delete;
36 ~Environment() = delete;
48 }; 37 };
49 38
50 } // namespace mojo 39 } // namespace mojo
51 40
52 #endif // MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_ 41 #endif // MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/tests/validation_unittest.cc ('k') | mojo/public/cpp/environment/lib/environment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698