Remove requirement that mojo::Environment be instantiated.

Remove requirement that mojo::Environment be instantiated.

In fact, make it not instantiatable.

Arguably, the class should be removed and its static methods replaced
with free functions. But I'll leave that for another day.

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/dc998703fec2d972e1d2f4b8736018310649553c

[vardhan, 2016-05-20 18:38:06]

lgtm with comments/questions

https://codereview.chromium.org/1997473005/diff/20001/mojo/public/cpp/environ...
File mojo/public/cpp/environment/environment.h (left):

https://codereview.chromium.org/1997473005/diff/20001/mojo/public/cpp/environ...
mojo/public/cpp/environment/environment.h:28: Environment(const MojoAsyncWaiter*
default_async_waiter,
if the default async waiter or default logger do need to be initialized for some
reason, I guess we should now expect a GetDefaultLogger() to lazy-initialize?

https://codereview.chromium.org/1997473005/diff/20001/mojo/public/cpp/environ...
mojo/public/cpp/environment/environment.h:32: static const MojoAsyncWaiter*
GetDefaultAsyncWaiter();
should we have a SetDefaultAsyncWaitier() as well?

[viettrungluu, 2016-05-20 21:08:53]

Description was changed from

==========
Remove requirement that mojo::Environment be instantiated.

In fact, make it not instantiatable.

Arguably, the class should be removed and its static methods replaced
with free functions. But I'll leave that for another day.

R=vardhan@google.com
==========

to

==========
Remove requirement that mojo::Environment be instantiated.

In fact, make it not instantiatable.

Arguably, the class should be removed and its static methods replaced
with free functions. But I'll leave that for another day.

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/dc998703fec2d972e1d2f4b8736...
==========

[viettrungluu, 2016-05-20 21:08:55]

Committed patchset #3 (id:40001) manually as
dc998703fec2d972e1d2f4b8736018310649553c (presubmit successful).

[viettrungluu, 2016-05-20 21:09:46]

Thanks.

https://codereview.chromium.org/1997473005/diff/20001/mojo/public/cpp/environ...
File mojo/public/cpp/environment/environment.h (left):

https://codereview.chromium.org/1997473005/diff/20001/mojo/public/cpp/environ...
mojo/public/cpp/environment/environment.h:28: Environment(const MojoAsyncWaiter*
default_async_waiter,
On 2016/05/20 18:38:06, vardhan wrote:
> if the default async waiter or default logger do need to be initialized for
some
> reason, I guess we should now expect a GetDefaultLogger() to lazy-initialize?

Either that, or some implementations may require explicit initialization (as I
tried to explain in the comment I added).

https://codereview.chromium.org/1997473005/diff/20001/mojo/public/cpp/environ...
mojo/public/cpp/environment/environment.h:32: static const MojoAsyncWaiter*
GetDefaultAsyncWaiter();
On 2016/05/20 18:38:06, vardhan wrote:
> should we have a SetDefaultAsyncWaitier() as well?

Done.