ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc - Issue 1997473004: Snippets are enabled when search suggestions are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

Issue 1997473004: Snippets are enabled when search suggestions are enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

diff --git a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

index e57b3321689c0403537eaa0d496727f2231a61cc..0afb76841013e143c7ea55d33d5da2e635e3ba28 100644

--- a/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

+++ b/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc

@@ -104,8 +104,9 @@ IOSChromeNTPSnippetsServiceFactory::BuildServiceInstanceFor(

base::SequencedWorkerPool::GetSequenceToken(),

base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);

return base::WrapUnique(new ntp_snippets::NTPSnippetsService(

- chrome_browser_state->GetPrefs(), sync_service, suggestions_service,

- task_runner, GetApplicationContext()->GetApplicationLocale(), scheduler,

+ false /* enabled */, chrome_browser_state->GetPrefs(), sync_service,

+ suggestions_service, task_runner,

+ GetApplicationContext()->GetApplicationLocale(), scheduler,

base::WrapUnique(new ntp_snippets::NTPSnippetsFetcher(

signin_manager, token_service, request_context,

base::Bind(&ParseJson),

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service_unittest.cc ('k') | no next file » | no next file with comments »