chrome/browser/resources/settings/about_page/about_page_browser_proxy.js - Issue 1997453006: MD Settings: About page, updating buttons based on current update status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

Issue 1997453006: MD Settings: About page, updating buttons based on current update status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@about_page_main3

Patch Set: Nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/about_page/about_page.js ('K') | « chrome/browser/resources/settings/about_page/about_page.js ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | chrome/test/data/webui/settings/about_page_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

diff --git a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js b/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

index 3adbabf1b1d3bfe5338c53dda3e12b0ec01ec5e6..90c60f9a473196b82439c333250e38a274fce90a 100644

--- a/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

+++ b/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js

@@ -54,8 +54,8 @@ var UpdateStatus = {

/**

* @typedef {{

* status: !UpdateStatus,

- * progress: number,

- * message: string,

+ * progress: (number|undefined),

tommycli 2016/05/20 22:53:18 Looking at the C++ handler, these are always defin

dpapad 2016/05/20 23:25:35 Test code but also prod code (see about_page.js wh

+ * message: (string|undefined),

* }}

var UpdateStatusChangedEvent;