Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1997453005: [Devtools] If already Data URI remove Copy Image URL in network (Closed)

Created:
4 years, 7 months ago by allada
Modified:
4 years, 7 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] If already Data URI remove Copy Image URL in network Removed "Copy Image URL" if is already a data URL. Also renamed it to "Data URI" as it is the proper name. BUG=610789 R=lushnikov Committed: https://crrev.com/055fa6e5f782a307af35464e1d1dd1075b1cf99b Cr-Commit-Position: refs/heads/master@{#394878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/source_frame/ImageView.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
allada
PTL
4 years, 7 months ago (2016-05-19 18:48:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997453005/1
4 years, 7 months ago (2016-05-19 18:49:07 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 20:14:04 UTC) #5
caseq
lgtm
4 years, 7 months ago (2016-05-19 21:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997453005/1
4 years, 7 months ago (2016-05-19 21:37:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 21:45:03 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:46:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/055fa6e5f782a307af35464e1d1dd1075b1cf99b
Cr-Commit-Position: refs/heads/master@{#394878}

Powered by Google App Engine
This is Rietveld 408576698