Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1997453004: Revert of [test] add tests for async function stacktraces (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] add tests for async function stacktraces (patchset #1 id:1 of https://codereview.chromium.org/1995723004/ ) Reason for revert: Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3575 Original issue's description: > [test] add tests for async function stacktraces > > BUG=v8:4483 > R=littledan@chromium.org > > Committed: https://crrev.com/02f228eccdfcfab4081c2494ade52e54702b692c > Cr-Commit-Position: refs/heads/master@{#36365} TBR=littledan@chromium.org,caitpotter88@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Committed: https://crrev.com/ad7939e71de4a67fb77a585b4eda9298cb130064 Cr-Commit-Position: refs/heads/master@{#36369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -115 lines) Patch
D test/mjsunit/harmony/async-function-stacktrace.js View 1 chunk +0 lines, -115 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [test] add tests for async function stacktraces
4 years, 7 months ago (2016-05-19 14:50:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997453004/1
4 years, 7 months ago (2016-05-19 14:51:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 14:51:14 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 14:51:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad7939e71de4a67fb77a585b4eda9298cb130064
Cr-Commit-Position: refs/heads/master@{#36369}

Powered by Google App Engine
This is Rietveld 408576698