Issue 199743008: Enable device_orientation_event_pump_unittest on Windows platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199743008: Enable device_orientation_event_pump_unittest on Windows platform. (Closed)

Created:
6 years, 9 months ago by timvolodine

Modified:
6 years, 4 months ago

Reviewers:
Michael van Ouwerkerk

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Enable device_orientation_event_pump_unittest on Windows platform. Fix failing tests on windows platform. BUG=344379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287574

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -25 lines)			Patch
	M	content/renderer/device_sensors/device_orientation_event_pump_unittest.cc	View	1	4 chunks	+7 lines, -25 lines	0 comments	Download

Total messages: 7 (0 generated)

timvolodine

On 2014/03/20 12:55:51, Michael van Ouwerkerk wrote: > lgtm nice! thanks Michael!

6 years, 9 months ago (2014-03-20 15:47:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/199743008/20001

6 years, 4 months ago (2014-08-05 16:16:22 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-05 18:12:58 UTC) #6

Message was sent while issue was closed.

Change committed as 287574