Issue 199743006: Fix C++ compilation issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199743006: Fix C++ compilation issue (Closed)

Created:
6 years, 9 months ago by rossberg

Modified:
6 years, 9 months ago

Reviewers:
tfarina, marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix C++ compilation issue TBR=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19977

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/preparser.h	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

https://codereview.chromium.org/199743006/diff/1/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/199743006/diff/1/src/preparser.h#newcode1629 src/preparser.h:1629: if (!this->IsValidLeftHandSide(expression)) { what was the error? Usually it ...

6 years, 9 months ago (2014-03-19 17:33:01 UTC) #3

rossberg

6 years, 9 months ago (2014-03-19 18:13:15 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/199743006/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/199743006/diff/1/src/preparser.h#newcode1629
src/preparser.h:1629: if (!this->IsValidLeftHandSide(expression)) {
On 2014/03/19 17:33:01, tfarina wrote:
> what was the error? Usually it is good to paste it in the CL description. Was
> this clang only?

The usual C++ idiocy about template parameter dependent name resolution, that
only some compilers bother to diagnose. Why?

Expand Messages | Collapse Messages