Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 199743003: Web Animation API: Add use counter for Animation constructors (Closed)

Created:
6 years, 9 months ago by rjwright
Modified:
6 years, 9 months ago
Reviewers:
dstockwell, shans
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@APIUseCounter
Visibility:
Public.

Description

Web Animation API: Add use counter for Animation constructors DEPENDS ON: https://codereview.chromium.org/198693002/ BUG=352493, 352490 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169721

Patch Set 1 #

Patch Set 2 : Rebase onto parent branch #

Patch Set 3 : Rebased onto updated parent branch #

Total comments: 1

Patch Set 4 : Rename UseCounter entries to AnimationConstructor* #

Patch Set 5 : Update and rebase #

Patch Set 6 : Fixed bad rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/core/animation/Animation.cpp View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rjwright
Ptal. Almost identical to https://codereview.chromium.org/198693002/. Once someone lgtm that one + this one I will ...
6 years, 9 months ago (2014-03-14 01:41:16 UTC) #1
rjwright
The count call can't go in the IDL because you can't put constructors in the ...
6 years, 9 months ago (2014-03-14 04:34:22 UTC) #2
dstockwell
lgtm https://codereview.chromium.org/199743003/diff/40001/Source/core/frame/UseCounter.h File Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/199743003/diff/40001/Source/core/frame/UseCounter.h#newcode312 Source/core/frame/UseCounter.h:312: NewAnimationKeyframeListEffectObjectTiming = 295, instead of NewAnimation, perhaps AnimationConstructor
6 years, 9 months ago (2014-03-20 05:24:16 UTC) #3
rjwright
The CQ bit was checked by rjwright@chromium.org
6 years, 9 months ago (2014-03-20 06:19:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjwright@chromium.org/199743003/60001
6 years, 9 months ago (2014-03-20 06:19:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 06:19:17 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-20 06:19:18 UTC) #7
rjwright
The CQ bit was checked by rjwright@chromium.org
6 years, 9 months ago (2014-03-21 05:00:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjwright@chromium.org/199743003/80001
6 years, 9 months ago (2014-03-21 05:00:37 UTC) #9
rjwright
The CQ bit was unchecked by rjwright@chromium.org
6 years, 9 months ago (2014-03-21 05:02:20 UTC) #10
rjwright
The CQ bit was checked by rjwright@chromium.org
6 years, 9 months ago (2014-03-21 05:18:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjwright@chromium.org/199743003/100001
6 years, 9 months ago (2014-03-21 05:18:59 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 06:30:50 UTC) #13
Message was sent while issue was closed.
Change committed as 169721

Powered by Google App Engine
This is Rietveld 408576698