Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 19974006: Revert 213298 "Moves calling OnAutoHideState to when exactly the..." (Closed)

Created:
7 years, 5 months ago by rlarocque
Modified:
7 years, 5 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 213298 "Moves calling OnAutoHideState to when exactly the..." Seems to be related to buildbot failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/22366 > Moves calling OnAutoHideState to when exactly the state has changed (2nd) > > This method is called when a window is maximized or fullscreen. > > The first attempt was reverted due to a test failure in LauncherTooltipManagerTest, > and it turns out that's because the observer method is not emitted > correctly. > > BUG=249509 > TBR=harrym@chromium.org, jamescook@chromium.org > TEST=manually > > Review URL: https://chromiumcodereview.appspot.com/20056003 TBR=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M trunk/src/ash/shelf/shelf_layout_manager.cc View 3 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rlarocque
7 years, 5 months ago (2013-07-24 01:36:09 UTC) #1
rlarocque
7 years, 5 months ago (2013-07-24 01:36:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r213315.

Powered by Google App Engine
This is Rietveld 408576698